-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize ProcessListVRS to reuse existing Hours if possible #154
Comments
In release 3.79, I added code to remove the deleted Hours from the Recycle Bin. |
**lurch: add |
Tracking W-016882 |
Another reason to do this optimization is to preserve additional Hours Status changes that the user may have made. For example, if the VRS has a status of Confirmed, but later the user has updated some past Hours to Status=No-Show, we don't want ProcessListJRS to have a side effect of deleting the No-Show Hours, and recreating them with Confirmed. Also note that ProcessListVRS will look at ALL shifts for the Job, rather than just new shifts added due to a new or updated JRS. So adding a new JRS has a side effect of deleting/recreating Hours that have nothing to do with the new JRS added. |
While investigating this issue, also review where we look at Status, to see if we can do more to support custom Status values. |
…ments optimize ProcessListVRS to reuse existing Hours if possible. Issue #154
Included in beta release 3.90 (Beta 3) |
When ProcessListJRS calls ProcessListVRS, we delete all Hours that aren't completed or canceled, and then recreate them. Since this happens every time the scheduled job runs, it would be better to reuse existing hours if they still meet the VRS schedule. Not a trivial code change, however.
The text was updated successfully, but these errors were encountered: