Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip modules without tests #29

Closed
wants to merge 1 commit into from
Closed

Skip modules without tests #29

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/main/java/org/pitest/maven/PmpMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,6 +256,11 @@ protected RunDecision shouldRun()
message = projectName + " is a skipped module";
theDecision.addReason(message);
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how hard would it be to add a test case for this? Or should we wait for #11 to start adding tests on new code paths ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could be done but would probably require a lot of mocking, therefore, I would prefer to add tests after #11 has been merged.

if (targetTests.isEmpty()) {
message = projectName + " contains no tests";
theDecision.addReason(message);
}

if (shouldDisplayOnly())
{
Expand Down