Skip modules without tests #29
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrorijo91
reviewed
Sep 10, 2018
| @@ -256,6 +256,11 @@ protected RunDecision shouldRun() | |||
| message = projectName + " is a skipped module"; | |||
| theDecision.addReason(message); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
how hard would it be to add a test case for this? Or should we wait for #11 to start adding tests on new code paths ?
There was a problem hiding this comment.
I could be done but would probably require a lot of mocking, therefore, I would prefer to add tests after #11 has been merged.
|
Closing old PR. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If no test classes are found, the property target tests will be empty. As a consequence, PIT will derive patterns to match test classes from the packages in the application code. This may include undesired tests from other modules (and can cause ClassNotFoundExceptions). With this fix, modules without test classes will be skipped.