Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create test cases for existing subsystems #189

Open
3 of 6 tasks
TheJJ opened this issue Jan 8, 2015 · 8 comments
Open
3 of 6 tasks

Create test cases for existing subsystems #189

TheJJ opened this issue Jan 8, 2015 · 8 comments
Labels
code quality Does not alter behavior, but beauty of our code just do it You can start working on this, there should be nothing left to discuss lang: c++ Done in C++ code

Comments

@TheJJ
Copy link
Member

TheJJ commented Jan 8, 2015

Because reasons we should add more tests to the code.

Substems with test coverage:

  • Pathfinding
  • Jobmanager
  • Terrain blending
  • Coordinate system
  • Asset manager
  • Logger

For the missing ones, please create some creative tests.
An example how that could look like can be seen in libopenage/datastructure/.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
@TheJJ TheJJ added lang: c++ Done in C++ code code quality Does not alter behavior, but beauty of our code labels Jan 8, 2015
@sreejithr
Copy link
Contributor

Hey, I can write unit tests for you. I'm still reading up the codebase. But I'll start right away. Anything in particular you guys want from me?

@TheJJ
Copy link
Member Author

TheJJ commented Jan 19, 2015

@sreejithr: Whatever test you want to implement, go for it 😄. If you need any help on the codebase the best would be joining our IRC and asking there.

@TheJJ
Copy link
Member Author

TheJJ commented Feb 7, 2015

#197 will benefit greatly from this.

@ghost
Copy link

ghost commented Mar 3, 2015

Created tests for pathfinding logic in pull request #241

TheJJ added a commit that referenced this issue Mar 16, 2015
@TheJJ
Merge pull request #241 from jgelderloos/path_testing_#189
4b29d21 
Pathfinding testing #189
@TheJJ TheJJ added good first issue Suitable for newcomers just do it You can start working on this, there should be nothing left to discuss labels Apr 12, 2015
@kukinsula
Copy link

pull request for testing the file sink logging: #309

@sreejithr
Copy link
Contributor

Made existing testcases for JobManager test with atleast 10 jobs in parallel (#310).

@simonsan
Copy link
Contributor

simonsan commented Jul 1, 2019 •
edited
Loading

This is an evergreen to raise testing coverage of our code. Also it is a good first issue and we can just do it. I will pin this issue to bring more attention to it for new people looking into the issues that want to do stuff.

@simonsan simonsan pinned this issue Jul 1, 2019
@simonsan simonsan added the hacktoberfest For newcomers from Hacktoberfest event label Oct 8, 2019
@heinezen heinezen removed the hacktoberfest For newcomers from Hacktoberfest event label Nov 25, 2019
@simonsan
Copy link
Contributor

An example that has been merged already can be seen here:
https://github.com/SFTtech/openage/pull/241/files

@heinezen heinezen unpinned this issue Nov 18, 2020
@TheJJ TheJJ moved this to To do in openage code quality Feb 27, 2023
@heinezen heinezen moved this to game simulation in openage beginner tasks Sep 10, 2023
@heinezen heinezen moved this to code quality in openage beginner tasks Sep 10, 2023
@heinezen heinezen removed the good first issue Suitable for newcomers label Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code quality Does not alter behavior, but beauty of our code just do it You can start working on this, there should be nothing left to discuss lang: c++ Done in C++ code
Projects
openage code quality
Status: To do
Milestone
No milestone
Development

No branches or pull requests
5 participants
@TheJJ @sreejithr @kukinsula @heinezen @simonsan