routed spatial_counts and spatial_magnitude_counts through region class

[wsavran]

• added acceptance tests for these functions
• fixed bin1d_vec doesn't return correct value for right_continuous with scalar input #116 -- issue with bin1d_vec for scalar values
• fixed Make catalog binning work with functions directly from the Region class #121 -- routing spatial_counts and spatial_magnitude counts through region class

[wsavran]

@khawajasim do you mind reviewing this before i merge?

[codecov-commenter]

Codecov Report

Merging #122 (26406c2) into master (40c28bb) will increase coverage by 0.40%.
The diff coverage is 80.95%.

❗ Current head 26406c2 differs from pull request most recent head 7206a3b. Consider uploading reports for the commit 7206a3b to get more accurate results

@@            Coverage Diff             @@
##           master     #122      +/-   ##
==========================================
+ Coverage   56.88%   57.28%   +0.40%     
==========================================
  Files          19       19              
  Lines        3115     3121       +6     
  Branches      451      453       +2     
==========================================
+ Hits         1772     1788      +16     
+ Misses       1237     1225      -12     
- Partials      106      108       +2     

Impacted Files	Coverage Δ
csep/core/catalogs.py	59.47% <77.77%> (+1.61%)	⬆️
csep/utils/calc.py	53.57% <100.00%> (+3.57%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40c28bb...7206a3b. Read the comment docs.

[khawajasim]

@khawajasim do you mind reviewing this before i merge?

Thanks. I looked through the code. Everything seems alright to my understanding.

I have one question though. I am not sure whether it is a right question or not. Why there is no change in region.py and evaluations.py? I was thinking that routing subject functions through region class means that these functions will be added as a member functions to region2D class. And eventually called in evaluations.py through that way. Or I was thinking it the wrong way?

[wsavran]

not a bad question at all! ultimately it came down to a choice of implementation. i decided to define the methods at the catalog level, because i wanted to keep the definition of the region objects as simple as possible. this way, all a region needs to do is define in the get_index_of function and it can be used in the catalog or evaluations.

we can always change this down the road so long as the functions on the catalog class do as they are intended.