- 
                Notifications
    You must be signed in to change notification settings 
- Fork 33
WireMod utility functions for SBN #595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/SBN2025A
Are you sure you want to change the base?
Conversation
sbncode v10_06_00_04 for larsoft v10_06_00_02
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this look good to me.
One commented out block that could be cleaned up, but nothing worth blocking the merge over
| if (planeXInWindow(shifted_edep.X(), plane, *curTPCGeomPtr, offset + tickOffset)) | ||
| target_roi_vec.emplace_back(wireReadout->PlaneWireToChannel(edep_wireID), std::round(planeXToTick(shifted_edep.X(), plane, *curTPCGeomPtr, offset + tickOffset))); | ||
| } | ||
| /* | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this block is unused we should probably remove it to keep the utility as clean as possible.
The loop above, (while, imo, having less legible syntax) does the trick just fine
Description
This PR adds utility functions for WireMod to sbncode. Specifically, this adds:
We plan for ICARUS & SBND to both maintain separate experiment-specific modules that use this common utility. In particular,
This is the V10-compatible veresion of PR#499 by @hausnerh.