Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep the comments #19

Closed
katat opened this issue Jul 19, 2019 · 3 comments · Fixed by #25
Closed

Keep the comments #19

katat opened this issue Jul 19, 2019 · 3 comments · Fixed by #25

Comments

@katat
Copy link

katat commented Jul 19, 2019

Hi @RyuuGan,

The latest release is awesome!
I have one request. Can we make it configurable to keep the comments?

Best regards,
Kata
@conlan conlan mentioned this issue Nov 26, 2019
Closed
@conlan
Copy link

conlan commented Nov 26, 2019 •
edited
Loading

Bumping this issue as I ran into it while using the truffle-plugin-verify package here: https://github.com/rkalis/truffle-plugin-verify.

Would be great to have a way for comments to be preserved:

Screen Shot 2019-11-26 at 12 25 10 AM7

Screen Shot 2019-11-26 at 12 24 15 AM

Thanks again for the awesome work: @RyuuGan

RyuuGan added a commit that referenced this issue Dec 1, 2019
@RyuuGan
feat(comments): add support for comments inside exports
d28f414 
add option `removeComments` (default `true`) to leave the comments inside exports.
Relates #19
RyuuGan added a commit that referenced this issue Jan 4, 2020
@RyuuGan
feat(comments): add support for comments inside exports
776d053 
add option `removeComments` (default `true`) to leave the comments inside exports.
Relates #19
This was referenced Jan 5, 2020
Merged
Merged
@RyuuGan
Copy link
Owner

RyuuGan commented Jan 5, 2020

Should be fixed in 1.2.0

@RyuuGan RyuuGan mentioned this issue Jan 7, 2020
Closed
@rkalis rkalis mentioned this issue May 12, 2020
Closed
@rkalis
Copy link

rkalis commented May 12, 2020

@alsco77 reported an issue with comments preservation (rkalis/truffle-plugin-verify#31). It appears that comments outside of contract definitions are not preserved.

@RyuuGan RyuuGan reopened this May 16, 2020
RyuuGan added a commit that referenced this issue May 17, 2020
@RyuuGan
Merge pull request #35 from RyuuGan/va/comments
8754c6d 
Support comments on top Level

relates #19
@RyuuGan RyuuGan mentioned this issue May 17, 2020
Merged
@RyuuGan RyuuGan closed this as completed May 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Exports and add option to leave comments (false by default) RyuuGan/sol-merger
4 participants
@conlan @RyuuGan @katat @rkalis