Skip to content
This repository has been archived by the owner on Jan 4, 2024. It is now read-only.

Missing Comments? #23

Closed
conlan opened this issue Nov 26, 2019 · 2 comments
Closed

Missing Comments? #23

conlan opened this issue Nov 26, 2019 · 2 comments
Labels
bug Something isn't working

Comments

@conlan
Copy link

conlan commented Nov 26, 2019

Hey there! Loving this tool so far -- the only issue is that it appears that comments aren't preserved after verifying?

You can see comments here:

Screen Shot 2019-11-26 at 12 25 10 AM

but not showing up on etherscan verification:

Screen Shot 2019-11-26 at 12 24 15 AM

Lemme know if you need any more details or if this is a known issue :)

@rkalis
Copy link
Owner

rkalis commented Nov 26, 2019

Hi @conlan, thanks for opening this issue. A similar point was raised by @prestwich in #15 about seemingly random linebreaks, that turned out to be removed comments. Comments are removed because truffle-plugin-verify uses sol-merger to flatten source files, which deletes the comments.

In #15 @RyuuGan said he didn't want to implement comment parsing in sol-merger, but I can imagine that he'd be open to a good PR that adds preservation of comments.

If it's important that comments are preserved, the best way would probably be to raise such a PR to the sol-merger repository.

@conlan
Copy link
Author

conlan commented Nov 26, 2019

Hey @rkalis okay thanks! I've found actually the exact issue here: RyuuGan/sol-merger#19. Will move this over there!

@conlan conlan closed this as completed Nov 26, 2019
@rkalis rkalis added the bug Something isn't working label May 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants