ctutils: add Choice::from_u8* and from_u16*
#1311
Merged
+160
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a set of `Choice` constructors following the same pattern we already implement for `u32`, `u64`, and `u128`. Interestingly, this gives us an alternative to `Choice::new` which doesn't have to deal with out-of-range values: `Choice::from_u8_lsb`. With that possibility noted, this also documents `Choice::new` may be deprecated in the future. Ideally it could be removed before final `crypto-bigint` releases. Regarding `u16`, I actually ran into a real-world case where this would've been helpful inside `crypto-bigint`.
Merged
tarcieri
added a commit
that referenced
this pull request
Dec 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a set of
Choiceconstructors following the same pattern we already implement foru32,u64, andu128.Interestingly, this gives us an alternative to
Choice::newwhich doesn't have to deal with out-of-range values:Choice::from_u8_lsb. With that possibility noted, this also documentsChoice::newmay be deprecated in the future. Ideally it could be removed before finalcrypto-bigintreleases.Regarding
u16, I actually ran into a real-world case where this would've been helpful insidecrypto-bigint.