ctutils: impl From<u8> for Choice
#1309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the main way `subtle` constructs `Choice` so it's important for backwards compatibility. It seems like if we had `from_u8_lsb`, we could avoid the panic condition by always masking the input `u8`. We don't yet, but this commit also leaves a comment to consider deprecating both this `From<u8>` impl and `Choice::new` in the future.
Merged
tarcieri
added a commit
that referenced
this pull request
Dec 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the main way
subtleconstructsChoiceso it's important for backwards compatibility.It seems like if we had
from_u8_lsb, we could avoid the panic condition by always masking the inputu8. We don't yet, but this commit also leaves a comment to consider deprecating both thisFrom<u8>impl andChoice::newin the future.