elliptic-curve: bump MSRV to 1.56 #795
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Oh wow, that's annoying. It seems when we bump edition, we need to do entire repos at a time, as otherwise cargo will error out on Given that, I'm going to leave |
tarcieri
force-pushed
the
elliptic-curve/2021-edition-upgrade
branch
from
79448bd to
9de917d
Compare
tarcieri
changed the title
tarcieri
force-pushed
the
elliptic-curve/2021-edition-upgrade
branch
4 times, most recently
from
2946252 to
6b59dd6
Compare
The RustCrypto/formats repo was bumped to Rust 2021 edition, and some of those crates (e.g. `der`, `sec1`) are hard dependencies for the `elliptic-curve` crate: RustCrypto/formats#136 This is a corresponding Rust 2021 edition bump for the `elliptic-curve` crate, as well as the omnibus `crypto` crate whose MSRV is determined by the highest MSRV crate in this repo.
tarcieri
force-pushed
the
elliptic-curve/2021-edition-upgrade
branch
from
6b59dd6 to
efc36a7
Compare
Member
Author
|
I found a solution that allows That keeps the 2021 edition crates nicely out-of-band from the 2018 edition ones until they can be upgraded. |
tarcieri
added a commit
to RustCrypto/signatures
that referenced
this pull request
Oct 21, 2021
The `elliptic-curve` crate as well as format parsers including `der`, `sec1`, and `pkcs8` have all been bumped to the 2021 edition: RustCrypto/traits#795 This commit updates the `ecdsa` crate to the 2021 edition accordingly.
tarcieri
added a commit
to RustCrypto/signatures
that referenced
this pull request
Oct 21, 2021
The `elliptic-curve` crate as well as format parsers including `der`, `sec1`, and `pkcs8` have all been bumped to the 2021 edition: RustCrypto/traits#795 This commit updates the `ecdsa` crate to the 2021 edition accordingly.
tarcieri
added a commit
to RustCrypto/signatures
that referenced
this pull request
Oct 21, 2021
The `elliptic-curve` crate as well as format parsers including `der`, `sec1`, and `pkcs8` have all been bumped to the 2021 edition: RustCrypto/traits#795 This commit updates the `ecdsa` crate to the 2021 edition accordingly.
tarcieri
added a commit
to RustCrypto/elliptic-curves
that referenced
this pull request
Oct 21, 2021
The `elliptic-curve` and `ecdsa` crates as well as format parsers including `der`, `sec1`, and `pkcs8` have all been bumped to Rust 2021 edition: - RustCrypto/traits#795 - RustCrypto/signatures#384 This commit updates the crates in this repo accordingly.
tarcieri
added a commit
to RustCrypto/elliptic-curves
that referenced
this pull request
Oct 21, 2021
The `elliptic-curve` and `ecdsa` crates as well as format parsers including `der`, `sec1`, and `pkcs8` have all been bumped to Rust 2021 edition: - RustCrypto/traits#795 - RustCrypto/signatures#384 This commit updates the crates in this repo accordingly.
tarcieri
added a commit
to RustCrypto/elliptic-curves
that referenced
this pull request
Oct 21, 2021
The `elliptic-curve` and `ecdsa` crates as well as format parsers including `der`, `sec1`, and `pkcs8` have all been bumped to Rust 2021 edition: - RustCrypto/traits#795 - RustCrypto/signatures#384 This commit updates the crates in this repo accordingly.
tarcieri
added a commit
to RustCrypto/elliptic-curves
that referenced
this pull request
Oct 21, 2021
The `elliptic-curve` and `ecdsa` crates as well as format parsers including `der`, `sec1`, and `pkcs8` have all been bumped to Rust 2021 edition: - RustCrypto/traits#795 - RustCrypto/signatures#384 This commit updates the crates in this repo accordingly.
Merged
scv35
added a commit
to scv35/Signature-algorithms
that referenced
this pull request
Jul 4, 2025
The `elliptic-curve` crate as well as format parsers including `der`, `sec1`, and `pkcs8` have all been bumped to the 2021 edition: RustCrypto/traits#795 This commit updates the `ecdsa` crate to the 2021 edition accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RustCrypto/formats repo was bumped to Rust 2021 edition, and some of those crates (e.g.
der,sec1) are hard dependencies for theelliptic-curvecrate:RustCrypto/formats#136
To actually bump the crate to the 2021 edition, we need to bump the MSRV of the rest of the crates in the repo, so this commit only changes the MSRV and doesn't actually do a 2021 edition upgrade for theelliptic-curvecrate yet.