Rust 2021 edition upgrade #136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
commented
Oct 21, 2021
| }) => { | ||
| quote! { | ||
| impl#generics tls_codec::Size for #ident#generics { | ||
| impl #generics tls_codec::Size for #ident #generics { |
Member
Author
There was a problem hiding this comment.
@franziskuskiefer FYI, these were auto-corrected by cargo fix --edition:
error: prefix `impl` is unknown
--> tls_codec/derive/src/lib.rs:234:17
|
234 | impl#generics tls_codec::Size for #ident#generics {
| ^^^^ unknown prefix
|
= note: prefixed identifiers and literals are reserved since Rust 2021
help: consider inserting whitespace here
|
234 - impl#generics tls_codec::Size for #ident#generics {
234 + impl #generics tls_codec::Size for #ident#generics {
See: https://doc.rust-lang.org/edition-guide/rust-2021/reserving-syntax.html
Contributor
There was a problem hiding this comment.
👍🏻 well, if that's the only fix needed for 2021 I'm fine with that 😄
tarcieri
force-pushed
the
rust-2021-edition-upgrade
branch
2 times, most recently
from
528ab7d to
61d782d
Compare
Most of the crates in this repository were already MSRV 1.55 to take advantage of non-`Copy`/`Default` array constructors using the new const-generic `map` constructor. However, now that the 2021 edition is out, it would be a shame to bump to 1.55 instead of 1.56 when we're bumping MSRV anyway. This commit bumps `edition = "2021"`, also adding the new `rust-version = "1.56"` Cargo.toml attribute to properly signal MSRV. All crates have been checked using `cargo fix --edition`, however no attempts have yet been made at upgrading edition idioms.
tarcieri
force-pushed
the
rust-2021-edition-upgrade
branch
from
61d782d to
82cea22
Compare
tarcieri
added a commit
to RustCrypto/traits
that referenced
this pull request
Oct 21, 2021
The RustCrypto/formats repo was bumped to Rust 2021 edition, and some of those crates (e.g. `der`, `sec1`) are hard dependencies for the `elliptic-curve` crate: RustCrypto/formats#136 This is a corresponding Rust 2021 edition bump for the `elliptic-curve` crate, as well as the omnibus `crypto` crate whose MSRV is determined by the highest MSRV crate in this repo.
tarcieri
added a commit
to RustCrypto/traits
that referenced
this pull request
Oct 21, 2021
The RustCrypto/formats repo was bumped to Rust 2021 edition, and some of those crates (e.g. `der`, `sec1`) are hard dependencies for the `elliptic-curve` crate: RustCrypto/formats#136 To actually bump the crate to the 2021 edition, we need to bump the MSRV of the rest of the crates in the repo, so this commit only changes the MSRV and doesn't actually do a 2021 edition upgrade for the `elliptic-curve` crate yet.
tarcieri
added a commit
to RustCrypto/traits
that referenced
this pull request
Oct 21, 2021
The RustCrypto/formats repo was bumped to Rust 2021 edition, and some of those crates (e.g. `der`, `sec1`) are hard dependencies for the `elliptic-curve` crate: RustCrypto/formats#136 This is a corresponding Rust 2021 edition bump for the `elliptic-curve` crate, as well as the omnibus `crypto` crate whose MSRV is determined by the highest MSRV crate in this repo.
tarcieri
added a commit
to RustCrypto/traits
that referenced
this pull request
Oct 21, 2021
The RustCrypto/formats repo was bumped to Rust 2021 edition, and some of those crates (e.g. `der`, `sec1`) are hard dependencies for the `elliptic-curve` crate: RustCrypto/formats#136 This is a corresponding Rust 2021 edition bump for the `elliptic-curve` crate, as well as the omnibus `crypto` crate whose MSRV is determined by the highest MSRV crate in this repo.
tarcieri
added a commit
to RustCrypto/traits
that referenced
this pull request
Oct 21, 2021
The RustCrypto/formats repo was bumped to Rust 2021 edition, and some of those crates (e.g. `der`, `sec1`) are hard dependencies for the `elliptic-curve` crate: RustCrypto/formats#136 This is a corresponding Rust 2021 edition bump for the `elliptic-curve` crate, as well as the omnibus `crypto` crate whose MSRV is determined by the highest MSRV crate in this repo.
tarcieri
added a commit
to RustCrypto/traits
that referenced
this pull request
Oct 21, 2021
The RustCrypto/formats repo was bumped to Rust 2021 edition, and some of those crates (e.g. `der`, `sec1`) are hard dependencies for the `elliptic-curve` crate: RustCrypto/formats#136 This is a corresponding Rust 2021 edition bump for the `elliptic-curve` crate, as well as the omnibus `crypto` crate whose MSRV is determined by the highest MSRV crate in this repo.
tarcieri
added a commit
to RustCrypto/traits
that referenced
this pull request
Oct 21, 2021
The RustCrypto/formats repo was bumped to Rust 2021 edition, and some of those crates (e.g. `der`, `sec1`) are hard dependencies for the `elliptic-curve` crate: RustCrypto/formats#136 This is a corresponding Rust 2021 edition bump for the `elliptic-curve` crate, as well as the omnibus `crypto` crate whose MSRV is determined by the highest MSRV crate in this repo.
tarcieri
added a commit
to RustCrypto/traits
that referenced
this pull request
Oct 21, 2021
The RustCrypto/formats repo was bumped to Rust 2021 edition, and some of those crates (e.g. `der`, `sec1`) are hard dependencies for the `elliptic-curve` crate: RustCrypto/formats#136 This is a corresponding Rust 2021 edition bump for the `elliptic-curve` crate, as well as the omnibus `crypto` crate whose MSRV is determined by the highest MSRV crate in this repo.
Merged
This was referenced Nov 14, 2021
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the crates in this repository were already MSRV 1.55 to take advantage of non-
Copy/Defaultarray constructors using the new const-genericmapconstructor.However, now that the 2021 edition is out, it would be a shame to bump to 1.55 instead of 1.56 when we're bumping MSRV anyway.
This commit bumps
edition = "2021", also adding the newrust-version = "1.56"Cargo.toml attribute to properly signal MSRV.All crates have been checked using
cargo fix --edition, however no attempts have yet been made at upgrading edition idioms.