scrypt: make Params output len customization optional
#602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This more or less goes back to the original API prior to when #255 added output length customization, adding a separate constructor function for adding length customization. This keeps the output length out-of-the-way for users of the low-level `scrypt::scrypt` API. We've had several complaints about this (#415, #449, #596, #601), and hopefully this addresses them. Additionally, since this functionality is only relevant to users of the `password-hash` API, it's feature-gated on that as well.
tarcieri
pushed a commit
that referenced
this pull request
May 30, 2025
When scrypt used a dependency with `default-features = false`, the doc compilation will fail because `password_hash::PasswordHasher` will be unavailable (`password-hash` is only pulled `simple` feature is used). It did not show up in CI, because `password-hash` is also provided as a `dev-dependency` and is available when `cargo test` evaluates the documentation. Fixup #602
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This more or less goes back to the original API prior to when #255 added output length customization, adding a separate constructor function for adding length customization.
This keeps the output length out-of-the-way for users of the low-level
scrypt::scryptAPI. We've had several complaints about this (#415, #449, #596, #601), and hopefully this addresses them.Additionally, since this functionality is only relevant to users of the
password-hashAPI, it's feature-gated on that as well.