scrypt: fixup doc compilation #606
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When scrypt used a dependency with `default-features = false`, the doc compilation will fail because `password_hash::PasswordHasher` will be unavailable (`password-hash` is only pulled `simple` feature is used). It did not show up in CI, because `password-hash` is also provided as a `dev-dependency` and is available when `cargo test` evaluates the documentation.
|
@tarcieri any chance to make another release of scrypt after this? RustCrypto/formats#1847 for the downstream build that failed |
tarcieri
approved these changes
May 30, 2025
|
@baloo sure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When scrypt used a dependency with
default-features = false, the doc compilation will fail becausepassword_hash::PasswordHasherwill be unavailable (password-hashis only pulledsimplefeature is used).It did not show up in CI, because
password-hashis also provided as adev-dependencyand is available whencargo testevaluates the documentation.Fixup #602