feat: rename StreamTrait::play to start, add draining stop#1258
Open
roderickvd wants to merge 13 commits into
Open
feat: rename StreamTrait::play to start, add draining stop#1258roderickvd wants to merge 13 commits into
roderickvd wants to merge 13 commits into
Conversation
roderickvd
force-pushed
the
feat/start-pause-stop
branch
2 times, most recently
from
0101f48 to
f5cbdac
Compare
This was referenced Jul 4, 2026
Open
This was referenced Jul 4, 2026
roderickvd
force-pushed
the
feat/start-pause-stop
branch
from
f5cbdac to
a36d6d7
Compare
roderickvd
force-pushed
the
feat/start-pause-stop
branch
from
a36d6d7 to
9286187
Compare
roderickvd
force-pushed
the
feat/start-pause-stop
branch
from
9286187 to
a216772
Compare
roderickvd
force-pushed
the
feat/start-pause-stop
branch
from
a216772 to
6fd7141
Compare
roderickvd
force-pushed
the
feat/start-pause-stop
branch
from
6fd7141 to
aa9f4b3
Compare
roderickvd
force-pushed
the
feat/start-pause-stop
branch
from
39b7223 to
c7256cd
Compare
roderickvd
force-pushed
the
feat/start-pause-stop
branch
from
c7256cd to
f5ceda7
Compare
roderickvd
force-pushed
the
feat/start-pause-stop
branch
from
f5ceda7 to
562a304
Compare
roderickvd
force-pushed
the
feat/start-pause-stop
branch
from
c120173 to
37cc6a5
Compare
Comment on lines
+1494
to
1500
| // Unblock the worker in case the stream is dropped before start() was called. | ||
| // Idempotent: no effect if the worker is already running. | ||
| self.signal_ready(); | ||
| self.inner.dropping.store(true, Ordering::Release); | ||
| self.latch.release(); | ||
| self.inner.dropping.store(true, Ordering::Relaxed); | ||
| self.trigger.wakeup(); | ||
| if let Some(handle) = self.thread.take() { | ||
| let _ = handle.join(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces
start/pause/stopsemantics onStreamTraitwith drainingstop.Playback
On playback streams, the difference between pausing and stopping is that:
pausehalts as soon as possible, if necessary discarding buffered audiostop(timeout)drains, letting buffered output finish before halting.stopthus blocks until the buffer empties ortimeoutelapses.Capture
Capture streams have nothing to drain and halt immediately on
stop.Behavior details
playis now deprecated and forwards tostart.timeoutofNonewaits indefinitely;Some(Duration::ZERO)halts without draining.start.Backend support
stop, except WebAudio and AudioWorklet where the calling thread can't block.pausenow implements a soft-pause fallback when there is no hardware support.StreamStateatomics in ASIO and JACK fromAcquire/ReleasetoRelaxed(no associated data payload).Related
Fixes: