Add taskCreated event to API and subscribe to Cline events earlier#1942
Merged
cte merged 2 commits intoRooCodeInc:mainfrom Mar 24, 2025
Merged
Add taskCreated event to API and subscribe to Cline events earlier#1942cte merged 2 commits intoRooCodeInc:mainfrom
taskCreated event to API and subscribe to Cline events earlier#1942cte merged 2 commits intoRooCodeInc:mainfrom
Conversation
|
Collaborator
|
@cte can you review this one? |
Collaborator
|
Makes sense - thank you! |
cte
approved these changes
Mar 24, 2025
teddyOOXX
pushed a commit
to teddyOOXX/Roo-Code
that referenced
this pull request
Mar 28, 2025
…ooCodeInc#1917) (RooCodeInc#1942) * Reapply "Add IS_DEV and Hot Reloading to debug. (RooCodeInc#1895)" (RooCodeInc#1917) This reverts commit 25ea46a. * Update TODO to be more explicit. Update logic for checking IS_DEV * Update TODO with even more explanation. (Now with 2x more explanation per explanation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
taskStartedevent is not the first event generated by a task. BeforetaskStarted, some messages may be sent (e.g. by the checkpoint service). It would be good to havetaskCreatedevent that fires before any message is sent.Also it would be better to attach to Cline events before the "event loop" starts.
Implementation
Added
onCreatedcallback toClineOptionsthat is called after theClineis created, but before the task "event loop" is run.Replaced
ClineProvider'sclineAddedevent withclineCreatedevent that fires before the "event loop" starts.Screenshots
None.
How to Test
Not tested.
Get in Touch
Discord handle: wkordalski
Important
Add
taskCreatedevent to API and adjustClineevent subscription timing to occur before task loop starts.taskCreatedevent emission inAPIclass inapi.tswhen aClineis created.ClineProviderto emitclineCreatedevent before task event loop starts.onCreatedcallback toClineOptionsinCline.ts.onCreatedinClineconstructor before starting task loop.clineAddedtoclineCreatedinClineProviderandapi.ts.This description was created by
for c9cea1e. It will automatically update as commits are pushed.