Skip to content

[TR#146] Text Pair#209

Merged
Jeremy-Walton merged 3 commits intomainfrom
tr146-text-pair
Sep 29, 2023
Merged

[TR#146] Text Pair#209
Jeremy-Walton merged 3 commits intomainfrom
tr146-text-pair

Conversation

@Jeremy-Walton
Copy link
Member

@Jeremy-Walton Jeremy-Walton commented Sep 28, 2023

Task

TR #146

Why?

A title and subtitle pair has shown up as a common pattern desired. This aims to provide that along with an inline option to create a key value pattern.

What Changed

  • Remove the gap override from breadcrumb component as it did not work as intended
  • Add Text Pair component

Sanity Check

  • Have you updated any usage of changed tokens?
  • Have you updated the docs with any component changes?
  • Have you updated the dependency graph with any component changes?
  • Have you run linters?
  • Have you run prettier?
  • Have you tried building the css?
  • Have you tried building storybook?
  • Do you need to update the package version? Yes, bumped to 0.5.1

Screenshots

Screenshot 2023-09-28 at 4 48 48 PM Screenshot 2023-09-28 at 4 48 58 PM Screenshot 2023-09-28 at 4 49 05 PM Screenshot 2023-09-28 at 4 49 09 PM

@Jeremy-Walton Jeremy-Walton added bug Something isn't working Components Changes to a component labels Sep 28, 2023
@Jeremy-Walton Jeremy-Walton added this to the v0.5.1 milestone Sep 28, 2023
@Jeremy-Walton Jeremy-Walton self-assigned this Sep 28, 2023
@Jeremy-Walton Jeremy-Walton merged commit 2d4d851 into main Sep 29, 2023
@Jeremy-Walton Jeremy-Walton deleted the tr146-text-pair branch September 29, 2023 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Components Changes to a component

Development

Successfully merging this pull request may close these issues.

2 participants