Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: EmptyMotor class inherits from Motor(ABC) #779

Merged
merged 4 commits into from
Mar 4, 2025

Conversation

Gui-FernandesBR
Copy link
Member

@Gui-FernandesBR Gui-FernandesBR commented Mar 4, 2025

Pull request type

  • Code maintenance (refactoring, formatting, tests)

Checklist

  • Tests for the changes have been added (if needed)
  • Docs have been reviewed and added / updated
  • Lint (black rocketpy/ tests/) has passed locally
  • All tests (pytest tests -m slow --runslow) have passed locally
  • CHANGELOG.md has been updated (if relevant)

Current behavior

The EmptyMotor is a huge workaround

New behavior

The EmptyMotor ihnerits from the abstract Motor class

Breaking change

  • Yes, but small. Should we care about it at all?

Additional information

#778 needs this first

@Gui-FernandesBR Gui-FernandesBR requested a review from a team as a code owner March 4, 2025 02:22
@Gui-FernandesBR
Copy link
Member Author

This one closes #530

@Gui-FernandesBR Gui-FernandesBR self-assigned this Mar 4, 2025
Copy link

codecov bot commented Mar 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.09%. Comparing base (83aa20e) to head (57a0cea).
Report is 20 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #779      +/-   ##
===========================================
+ Coverage    76.42%   80.09%   +3.67%     
===========================================
  Files           95       96       +1     
  Lines        11090    11360     +270     
===========================================
+ Hits          8475     9099     +624     
+ Misses        2615     2261     -354     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@phmbressan phmbressan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work. Did you check if prints and plots from the super parent class are working? Maybe they need some special treatment, I am not sure.

If they are working fine, consider this approved.

@Gui-FernandesBR Gui-FernandesBR force-pushed the mnt/empty-motor-class-iherits branch from ac9dc40 to 18e298b Compare March 4, 2025 13:35
@Gui-FernandesBR
Copy link
Member Author

Good work. Did you check if prints and plots from the super parent class are working? Maybe they need some special treatment, I am not sure.

If they are working fine, consider this approved.

Yes they are working fine. I've added an integration test to cover that part.
All good.

@Gui-FernandesBR Gui-FernandesBR added Motors Every propulsion related issue or PR Refactor labels Mar 4, 2025
@Gui-FernandesBR Gui-FernandesBR linked an issue Mar 4, 2025 that may be closed by this pull request
@Gui-FernandesBR Gui-FernandesBR merged commit 4cc5d83 into develop Mar 4, 2025
7 checks passed
@Gui-FernandesBR Gui-FernandesBR deleted the mnt/empty-motor-class-iherits branch March 4, 2025 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Motors Every propulsion related issue or PR Refactor
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

MNT: EmptyMotor class inherits from Motor(ABC)
2 participants