-
-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MNT: EmptyMotor class inherits from Motor(ABC) #779
Conversation
This one closes #530 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #779 +/- ##
===========================================
+ Coverage 76.42% 80.09% +3.67%
===========================================
Files 95 96 +1
Lines 11090 11360 +270
===========================================
+ Hits 8475 9099 +624
+ Misses 2615 2261 -354 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work. Did you check if prints
and plots
from the super
parent class are working? Maybe they need some special treatment, I am not sure.
If they are working fine, consider this approved.
ac9dc40
to
18e298b
Compare
Yes they are working fine. I've added an integration test to cover that part. |
Pull request type
Checklist
black rocketpy/ tests/
) has passed locallypytest tests -m slow --runslow
) have passed locallyCHANGELOG.md
has been updated (if relevant)Current behavior
The EmptyMotor is a huge workaround
New behavior
The EmptyMotor ihnerits from the abstract Motor class
Breaking change
Additional information
#778 needs this first