BUG: update flight simulation logic to include burn start time #778
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Checklist
black rocketpy/ tests/
) has passed locallypytest tests -m slow --runslow
) have passed locallyCHANGELOG.md
has been updated (if relevant)Current behavior
In the Flight class, during two-stage rocket simulations, the second-stage motor is temporarily turned off after separation (except in hot separation cases). However, the current condition for applying power-on drag (
t < self.rocket.motor.burn_out_time
) incorrectly keeps power-on drag active during this period.New behavior
The condition has been updated to
self.rocket.motor.burn_start_time < t < self.rocket.motor.burn_out_time
inu_dot
andu_dot_generalized
to ensure proper handling of drag forces for both single- and multi-stage rockets. This ensures that power-off drag is correctly applied when the second-stage motor is off.Breaking change
Additional information
Firstly reported here: https://discord.com/channels/765037887016140840/1334492994631372810