chore!: remove Push_UseLegacy, Push_gcm_project_number and Push_gcm_api_key settings - #41899
Open
KevLehman wants to merge 2 commits into
Open
chore!: remove Push_UseLegacy, Push_gcm_project_number and Push_gcm_api_key settings#41899KevLehman wants to merge 2 commits into
KevLehman wants to merge 2 commits into
Conversation
Contributor
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: dbde615 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (62)
💤 Files with no reviewable changes (58)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📜 Recent review details⏰ Context from checks skipped due to timeout. (4)
🧰 Additional context used📓 Path-based instructions (2)**/*.{ts,tsx,js}📄 CodeRabbit inference engine (.cursor/rules/playwright.mdc)
Files:
apps/meteor/**📄 CodeRabbit inference engine (CLAUDE.md)
Files:
🔇 Additional comments (5)
WalkthroughThe change removes legacy push settings and their translations. Startup migration v340 deletes existing legacy settings. Google push credentials remain available through the current configuration path. ChangesLegacy push configuration
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This PR removes obsolete push settings and migrates stored values without changing the active push path; no actionable merge-blocking risk remains beyond normal checks. Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…-push-legacy-settings # Conflicts: # apps/meteor/server/startup/migrations/index.ts
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## release-9.0.0 #41899 +/- ##
================================================
Coverage ? 68.84%
================================================
Files ? 4135
Lines ? 158123
Branches ? 28074
================================================
Hits ? 108860
Misses ? 44122
Partials ? 5141
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
KevLehman
marked this pull request as ready for review
August 21, 2026 18:53
KevLehman
added
the
stat: QA assured
dionisio-bot
Bot
added
the
stat: ready to merge
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
sampaiodiego
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Removes the hidden
Push_UseLegacy,Push_gcm_project_numberandPush_gcm_api_keysettings, marked with a TODO for removal at 8.0.0. The legacy GCM provider they configured was shut down by Google on June 20, 2024, so they no longer had any effect — the send path already uses the FCM v1 API with OAuth credentials fromPush_google_api_credentials, and no code branches onPush_UseLegacy.Push_google_api_credentialsloses itsenableQueryonPush_UseLegacy(same effective state, since the flag defaulted tofalse)Push_Setting_Legacy_Warningi18n key and the three now-unused setting labels across all localesIssue(s)
https://rocketchat.atlassian.net/browse/CORE-2590
Steps to test or reproduce
Start the server against a database that has any of the three settings stored; after migration 340 runs, the documents are gone from
rocketchat_settings. Android push notifications keep working through the gateway or the FCM credentials inPush_google_api_credentials.Further comments
Summary by CodeRabbit
Removed Features
Localization