chore!: remove Troubleshoot_Disable_Statistics_Generator and Troubleshoot_Disable_Workspace_Sync settings

[KevLehman]

Proposed changes (including videos or screenshots)

Removes the hidden Troubleshoot_Disable_Statistics_Generator and Troubleshoot_Disable_Workspace_Sync settings, both marked with a TODO for removal at 7.0.0. No code reads either setting anymore and their i18n keys were already removed; only the registrations remained.

Migration v339 deletes both settings from the database, following the same pattern as v337 (FileUpload_S3_SignatureVersion).

Issue(s)

https://rocketchat.atlassian.net/browse/CORE-2588
https://rocketchat.atlassian.net/browse/CORE-2589

Steps to test or reproduce

Start the server against a database that has either setting stored; after migration 339 runs, both documents are gone from rocketchat_settings and they no longer appear in the admin settings.

Further comments

Summary by CodeRabbit

• Chores
  • Removed obsolete troubleshooting settings.
  • Added a migration to automatically clean up these settings for existing installations.

[dionisio-bot]

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

[changeset-bot]

⚠️ No Changeset found

Latest commit: 0a6b33f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[dionisio-bot]

Changeset mismatch

The PR title indicates a breaking change (!), but no changeset declares a major bump — at least one is required.

Please align the PR title, milestone and changesets.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 821f727f-ce31-478a-b155-b1041e034807

📥 Commits

Reviewing files that changed from the base of the PR and between 79a4126 and 0a6b33f.

📒 Files selected for processing (3)

• apps/meteor/server/settings/troubleshoot.ts
• apps/meteor/server/startup/migrations/index.ts
• apps/meteor/server/startup/migrations/v339.ts

💤 Files with no reviewable changes (1)

• apps/meteor/server/settings/troubleshoot.ts

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.

📜 Recent review details

⏰ Context from checks skipped due to timeout. (6)

• GitHub Check: cubic · AI code reviewer
• GitHub Check: Hacktron Security Check
• GitHub Check: 🔎 Code Check / TypeScript
• GitHub Check: 🔨 Test Unit / Unit Tests
• GitHub Check: 🔎 Code Check / Code Lint
• GitHub Check: 📦 Meteor Build (coverage)

🧰 Additional context used

📓 Path-based instructions (2)

**/*.{ts,tsx,js}

📄 CodeRabbit inference engine (.cursor/rules/playwright.mdc)

**/*.{ts,tsx,js}: Write concise, technical TypeScript/JavaScript with accurate typing in Playwright tests
Avoid code comments in the implementation

Files:

• apps/meteor/server/startup/migrations/index.ts
• apps/meteor/server/startup/migrations/v339.ts

apps/meteor/**

📄 CodeRabbit inference engine (CLAUDE.md)

The main Rocket.Chat Meteor application resides in apps/meteor/; place its application code there rather than in other monorepo areas.

Files:

• apps/meteor/server/startup/migrations/index.ts
• apps/meteor/server/startup/migrations/v339.ts

🧠 Learnings (2)

📚 Learning: 2026-02-26T19:25:44.063Z

Learnt from: gabriellsh
Repo: RocketChat/Rocket.Chat PR: 38778
File: packages/ui-voip/src/providers/useMediaSession.ts:192-192
Timestamp: 2026-02-26T19:25:44.063Z
Learning: In this repository (RocketChat/Rocket.Chat), Biome lint rules are not used even if a biome.json exists. When reviewing TypeScript files (e.g., packages/ui-voip/src/providers/useMediaSession.ts), ensure lint suggestions do not reference Biome-specific rules. Rely on general ESLint/TypeScript lint rules and project conventions instead.

Applied to files:

• apps/meteor/server/startup/migrations/v339.ts

📚 Learning: 2026-02-26T19:25:44.063Z

Learnt from: gabriellsh
Repo: RocketChat/Rocket.Chat PR: 38778
File: packages/ui-voip/src/providers/useMediaSession.ts:192-192
Timestamp: 2026-02-26T19:25:44.063Z
Learning: In the Rocket.Chat repository, do not reference Biome lint rules in code review feedback. Biome is not used even if biome.json exists; only reference Biome rules if there is explicit, project-wide usage documented. For TypeScript files, review lint implications without Biome guidance unless the project enables Biome rules.

Applied to files:

• apps/meteor/server/startup/migrations/v339.ts

🔇 Additional comments (2)

apps/meteor/server/startup/migrations/index.ts (1)

47-47: LGTM!

apps/meteor/server/startup/migrations/v339.ts (1)

1-11: LGTM!

---

Walkthrough

The PR removes two deprecated troubleshooting settings and adds migration v339 to delete existing instances. The migration is registered in the startup migration index.

Changes

Troubleshooting settings cleanup

Layer / File(s)	Summary
Register and execute migration v339 apps/meteor/server/startup/migrations/index.ts, apps/meteor/server/startup/migrations/v339.ts	The startup migration index imports v339. The migration deletes Troubleshoot_Disable_Statistics_Generator and Troubleshoot_Disable_Workspace_Sync with Settings.deleteMany.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 0a6b3

This localized change removes deprecated settings and cleans up their stored records; no actionable merge-blocking risk remains beyond normal checks and review.

Suggested labels: type: chore

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the removal of both deprecated Troubleshoot settings, which is the primary change in the pull request.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2 files.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (2)

• CORE-2588: Request failed with status code 401
• CORE-2589: Request failed with status code 401

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[codecov]

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (release-9.0.0@79a4126). Learn more about missing BASE report.

Additional details and impacted files

@@               Coverage Diff                @@
##             release-9.0.0   #41896   +/-   ##
================================================
  Coverage                 ?   68.82%           
================================================
  Files                    ?     4134           
  Lines                    ?   158124           
  Branches                 ?    28099           
================================================
  Hits                     ?   108836           
  Misses                   ?    44144           
  Partials                 ?     5144           

Flag	Coverage Δ
e2e	59.21% <ø> (?)
e2e-api	46.03% <50.00%> (?)
unit	70.51% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[cubic-dev-ai]

No issues found across 3 files

_{Re-trigger cubic}