Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Chat filtering breaks when "From" and "To" have the same date #35659

Merged
merged 1 commit into from
Apr 8, 2025

Conversation

dionisio-bot[bot]
Copy link
Contributor

@dionisio-bot dionisio-bot bot commented Mar 31, 2025

Backport of #35616

@dionisio-bot dionisio-bot bot requested a review from a team as a code owner March 31, 2025 10:22
Copy link

changeset-bot bot commented Mar 31, 2025

🦋 Changeset detected

Latest commit: 645ab52

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dionisio-bot dionisio-bot bot requested a review from aleksandernsilva March 31, 2025 10:22
Copy link
Contributor Author

dionisio-bot bot commented Mar 31, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

codecov bot commented Mar 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.47%. Comparing base (edc3c12) to head (645ab52).
Report is 5 commits behind head on release-7.4.2.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##           release-7.4.2   #35659   +/-   ##
==============================================
  Coverage          59.47%   59.47%           
==============================================
  Files               2830     2830           
  Lines              68570    68570           
  Branches           15175    15175           
==============================================
  Hits               40781    40781           
  Misses             25120    25120           
  Partials            2669     2669           
Flag Coverage Δ
unit 75.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35659/

Built to branch gh-pages at 2025-03-31 10:35 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@scuciatto scuciatto added the stat: QA assured Means it has been tested and approved by a company insider label Apr 2, 2025
@sampaiodiego sampaiodiego merged commit 2daf2c0 into release-7.4.2 Apr 8, 2025
50 of 51 checks passed
@sampaiodiego sampaiodiego deleted the backport-7.4.2-35616 branch April 8, 2025 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport stat: QA assured Means it has been tested and approved by a company insider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants