fix: Chat filtering breaks when "From" and "To" have the same date #35616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: 7a4eebf The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #35616 +/- ##
========================================
Coverage 59.72% 59.72%
========================================
Files 2829 2829
Lines 68243 68243
Branches 15126 15126
========================================
Hits 40759 40759
Misses 24876 24876
Partials 2608 2608
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
aleksandernsilva
force-pushed
the
fix/cc-chats-filters
branch
from
898361b to
a2b8667
Compare
aleksandernsilva
force-pushed
the
fix/cc-chats-filters
branch
from
a2b8667 to
9c8793a
Compare
aleksandernsilva
changed the title
lucas-a-pelegrino
approved these changes
Mar 26, 2025
tassoevan
approved these changes
Mar 27, 2025
tassoevan
approved these changes
Mar 27, 2025
tassoevan
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
|
/patch |
|
Pull request #35659 added to Project: "Patch 7.4.2" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
This PR fixes an issue where date-only strings used to filter the chats were incorrectly interpreted due to JavaScript's handling of
Dateobjects.Quick explanation:
When initializing a date with
new Date('2025-03-26'), JavaScript assumes the input is in UTC (2025-03-26T00:00:00.000Z). However, when converted to local time (e.g., in a UTC-3 timezone), the result shifts to2025-03-25T21:00:00.000Z, causing an unintended date mismatch.The fix ensures that dates are initialized in a way that preserves the intended local time, preventing incorrect dates from being sent to the rooms endpoints.
Issue(s)
SUP-753
Steps to test or reproduce
(Previously it would not show chats correctly)
Further comments