Skip to content

Conversation

@dougfabris
Copy link
Member

@dougfabris dougfabris commented Mar 7, 2025

Proposed changes (including videos or screenshots)

The error below is popping up, because we're using an invalid aria-hidden to the layout wrapper when displaying a modal, telling assistive technologies to not consider the main tree when the modal is on the screen. Since we do use a proper strategy to block the focus already, its not necessary to use this aria-hidden property.

image

Introduced here: #26826

Issue(s)

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Mar 7, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Mar 7, 2025

⚠️ No Changeset found

Latest commit: a6d9abd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dougfabris dougfabris added this to the 7.5.0 milestone Mar 7, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2025

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35429/

Built to branch gh-pages at 2025-03-10 13:48 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Mar 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.68%. Comparing base (0000781) to head (a6d9abd).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #35429      +/-   ##
===========================================
+ Coverage    59.64%   59.68%   +0.03%     
===========================================
  Files         2828     2829       +1     
  Lines        68541    68788     +247     
  Branches     15193    15240      +47     
===========================================
+ Hits         40884    41055     +171     
- Misses       25009    25074      +65     
- Partials      2648     2659      +11     
Flag Coverage Δ
unit 75.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dougfabris dougfabris force-pushed the chore/aria-hidden-invalid branch from a184b63 to 5c4e0f0 Compare March 10, 2025 14:43
@dougfabris dougfabris marked this pull request as ready for review March 10, 2025 17:55
@dougfabris dougfabris requested a review from a team as a code owner March 10, 2025 17:55
@MartinSchoeler MartinSchoeler added the stat: QA assured Means it has been tested and approved by a company insider label Mar 11, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Mar 11, 2025
@kodiakhq kodiakhq bot merged commit a8db7e5 into develop Mar 11, 2025
48 checks passed
@kodiakhq kodiakhq bot deleted the chore/aria-hidden-invalid branch March 11, 2025 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants