-
Notifications
You must be signed in to change notification settings - Fork 13.1k
chore: Remove invalid aria-hidden prop from layout wrapper
#35429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is ready to merge! 🎉 |
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #35429 +/- ##
===========================================
+ Coverage 59.64% 59.68% +0.03%
===========================================
Files 2828 2829 +1
Lines 68541 68788 +247
Branches 15193 15240 +47
===========================================
+ Hits 40884 41055 +171
- Misses 25009 25074 +65
- Partials 2648 2659 +11
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
a184b63 to
5c4e0f0
Compare
Proposed changes (including videos or screenshots)
The error below is popping up, because we're using an invalid
aria-hiddento the layout wrapper when displaying a modal, telling assistive technologies to not consider the main tree when the modal is on the screen. Since we do use a proper strategy to block the focus already, its not necessary to use this aria-hidden property.Introduced here: #26826
Issue(s)
Steps to test or reproduce
Further comments