Skip to content

Conversation

@ggazzo
Copy link
Member

@ggazzo ggazzo commented Sep 6, 2022

  • Prevents users from opening modals and get focused on other areas
  • Tells screen readers to ignore other areas that are not part of the form

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@ggazzo ggazzo requested a review from a team as a code owner September 6, 2022 21:12
@ggazzo ggazzo changed the title Chore: add aria hidden if modal is opened Chore: add aria hidden if modal is open Sep 6, 2022
@codecov
Copy link

codecov bot commented Sep 6, 2022

Codecov Report

Merging #26826 (3a76ae1) into develop (d30e08e) will not change coverage.
The diff coverage is n/a.

❗ Current head 3a76ae1 differs from pull request most recent head 8840409. Consider uploading reports for the commit 8840409 to get more accurate results

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #26826   +/-   ##
========================================
  Coverage    40.54%   40.54%           
========================================
  Files          799      799           
  Lines        18289    18289           
  Branches      1959     1959           
========================================
  Hits          7415     7415           
- Misses       10578    10580    +2     
+ Partials       296      294    -2     
Flag Coverage Δ
e2e 40.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo added stat: QA skipped stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Sep 8, 2022
@kodiakhq kodiakhq bot merged commit 343c5f1 into develop Sep 8, 2022
@kodiakhq kodiakhq bot deleted the chore/autofocus branch September 8, 2022 23:25
@tassoevan tassoevan mentioned this pull request Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants