Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add feature-preview tests for Enhanced navigation #33727

Merged
merged 5 commits into from
Oct 29, 2024

Conversation

juliajforesti
Copy link
Contributor

@juliajforesti juliajforesti commented Oct 23, 2024

SIDE-219
SIDE-218

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Copy link

changeset-bot bot commented Oct 23, 2024

⚠️ No Changeset found

Latest commit: 10f1009

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

dionisio-bot bot commented Oct 23, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link
Contributor

github-actions bot commented Oct 23, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33727/
on branch gh-pages at 2024-10-24 13:09 UTC

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.56%. Comparing base (b8e585a) to head (10f1009).
Report is 62 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #33727      +/-   ##
===========================================
+ Coverage    75.01%   75.56%   +0.54%     
===========================================
  Files          480      491      +11     
  Lines        21000    21533     +533     
  Branches      5329     5368      +39     
===========================================
+ Hits         15754    16271     +517     
- Misses        4619     4625       +6     
- Partials       627      637      +10     
Flag Coverage Δ
unit 75.56% <ø> (+0.54%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@juliajforesti juliajforesti added this to the 7.0 milestone Oct 23, 2024
@juliajforesti juliajforesti force-pushed the test/feature-preview branch 2 times, most recently from bb08bad to 467cfa1 Compare October 24, 2024 13:44
@juliajforesti juliajforesti force-pushed the test/feature-preview branch 3 times, most recently from 0d78448 to 07cf9dd Compare October 24, 2024 15:24
@juliajforesti juliajforesti marked this pull request as ready for review October 25, 2024 13:46
@juliajforesti juliajforesti requested a review from a team as a code owner October 25, 2024 13:46
@aleksandernsilva aleksandernsilva modified the milestones: 7.0, 7.1.0 Oct 29, 2024
@ggazzo ggazzo merged commit 6945645 into develop Oct 29, 2024
58 checks passed
@ggazzo ggazzo deleted the test/feature-preview branch October 29, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants