Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show Recent chats on the new sidebar #33489

Merged
merged 7 commits into from
Oct 18, 2024
Merged

feat: show Recent chats on the new sidebar #33489

merged 7 commits into from
Oct 18, 2024

Conversation

juliajforesti
Copy link
Contributor

@juliajforesti juliajforesti commented Oct 8, 2024

SIDE-175

Proposed changes (including videos or screenshots)

Kapture 2024-10-08 at 10 06 03

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Oct 8, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Oct 8, 2024

🦋 Changeset detected

Latest commit: 959bbab

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 37 packages
Name Type
@rocket.chat/i18n Minor
@rocket.chat/meteor Minor
@rocket.chat/mock-providers Patch
@rocket.chat/ui-contexts Major
@rocket.chat/web-ui-registration Major
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/ui-client Major
@rocket.chat/ui-voip Major
@rocket.chat/uikit-playground Patch
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-video-conf Major
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/model-typings Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/network-broker Patch
@rocket.chat/models Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 8, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33489/
on branch gh-pages at 2024-10-18 20:13 UTC

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.88%. Comparing base (687f1ef) to head (c42f879).
Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #33489   +/-   ##
========================================
  Coverage    74.88%   74.88%           
========================================
  Files          473      473           
  Lines        20810    20810           
  Branches      5314     5314           
========================================
  Hits         15583    15583           
  Misses        4602     4602           
  Partials       625      625           
Flag Coverage Δ
unit 74.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@juliajforesti juliajforesti added this to the 7.0 milestone Oct 8, 2024
@juliajforesti juliajforesti force-pushed the feat/recent-search branch 2 times, most recently from f03046c to 6967eca Compare October 11, 2024 18:51
@juliajforesti juliajforesti changed the base branch from develop to release-7.0.0 October 16, 2024 15:01
@juliajforesti juliajforesti marked this pull request as ready for review October 16, 2024 22:57
@juliajforesti juliajforesti requested a review from a team as a code owner October 16, 2024 22:57
@ggazzo ggazzo requested review from a team as code owners October 17, 2024 01:58
@ggazzo ggazzo force-pushed the release-7.0.0 branch 2 times, most recently from 08d4324 to 57dd899 Compare October 17, 2024 03:35
Base automatically changed from release-7.0.0 to develop October 17, 2024 04:28
An error occurred while trying to automatically change base from release-7.0.0 to develop October 17, 2024 04:28
An error occurred while trying to automatically change base from release-7.0.0 to develop October 17, 2024 04:28
@juliajforesti juliajforesti force-pushed the feat/recent-search branch 2 times, most recently from 67dd165 to 40f81c4 Compare October 17, 2024 11:09
@juliajforesti juliajforesti removed request for a team October 17, 2024 17:17
@@ -6642,5 +6642,6 @@
"Sidepanel_navigation": "Secondary navigation for teams",
"Sidepanel_navigation_description": "Display channels and/or discussions associated with teams by default. This allows team owners to customize communication methods to best meet their team’s needs. This is currently in feature preview and will be a premium capability once fully released.",
"Show_channels_description": "Show team channels in second sidebar",
"Show_discussions_description": "Show team discussions in second sidebar"
"Show_discussions_description": "Show team discussions in second sidebar",
"Recent": "Recent"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider Recent messages

@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Oct 18, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 18, 2024
@ggazzo ggazzo merged commit 34ed9ad into develop Oct 18, 2024
9 of 10 checks passed
@ggazzo ggazzo deleted the feat/recent-search branch October 18, 2024 21:07
This was referenced Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants