fix: Avoid notifying watch.settings on uncaught errors
#33376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this PR is ready to merge! 🎉 |
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #33376 +/- ##
========================================
Coverage 58.35% 58.35%
========================================
Files 2692 2692
Lines 65265 65265
Branches 14730 14730
========================================
Hits 38084 38084
Misses 24403 24403
Partials 2778 2778
Flags with carried forward coverage won't be shown. Click here to find out more. |
ricardogarim
requested changes
Sep 27, 2024
ricardogarim
previously approved these changes
Sep 27, 2024
ricardogarim
approved these changes
Sep 27, 2024
KevLehman
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
sampaiodiego
approved these changes
Sep 27, 2024
gabriellsh
added a commit
that referenced
this pull request
Sep 30, 2024
…ocket.Chat into feat/airgapped-restrictions * 'feat/airgapped-restrictions' of github.com:RocketChat/Rocket.Chat: (57 commits) fix: Async E2EE key exchange not working on develop (#33378) chore: Move Apps-Engine to monorepo (#32951) chore(Sidepanel): uses only local channels and discussions (#33387) chore: add gazzodown preview (#33279) fix: Avoid notifying `watch.settings` on uncaught errors (#33376) fix: race condition when forwarding livechat by splitting subscription removal (#33381) chore: Single Contact ID: improved typings and removed some duplicated code (#33324) ci: remove Jira-GitHub security integration (#33384) chore: add ui-composer to storybook (#33383) regression: `Sidepanel` sort requires refresh after room update (#33370) ci: use node20 for release action (#33343) Bump rocket.chat to 6.14.0-develop (#33366) chore: replace Meteor._localStorage -> Accounts.storageLocation (#33356) Release 6.13.0-rc.1 fix: Avoid destructuring `connectionData` when value is undefined (#33339) feat: Adds new admin feature preview setting management (#33212) regression: `Sidepanel` color highlight (#33342) chore: move common files to core-services (#33341) feat: Adds new admin feature preview setting management (#33212) chore: create network broker package (#33338) ...
gabriellsh
added a commit
that referenced
this pull request
Oct 2, 2024
…ocket.Chat into airgapped/composer-restriction * 'feat/airgapped-restrictions' of github.com:RocketChat/Rocket.Chat: (27 commits) review fix: skip invalid test for now consolidate restriction logic inside module remove constant from restriction module fix changeset Move tests to test folder remove wrong import fix proxyquire for airGappedRestrictionsCheck.ts test fix fix: Async E2EE key exchange not working on develop (#33378) Fix airgappedRestrictionswrapper tests Fix airgappedRestrictionCheck tests undo fix AirGappedRestriction logic Update logic and tests chore: Move Apps-Engine to monorepo (#32951) chore(Sidepanel): uses only local channels and discussions (#33387) chore: add gazzodown preview (#33279) wip fix: Avoid notifying `watch.settings` on uncaught errors (#33376) ...
abhinavkrin
pushed a commit
that referenced
this pull request
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
An uncaught error was happening (on my case, an invalid migration) and that caused the Error handler to kick in, updating the counter of
unhandled errors. This caused an error ofno broker set to broadcastas this error happened before broadcast was set.After an update, we're gonna manually update the cached collection for settings, so the value on the metrics is up to date.
Issue(s)
Steps to test or reproduce
Further comments
added also a log of what was the uncaught error