fix: Avoid notifying watch.settings on uncaught errors (#33376)

RocketChat · Sep 27, 2024 · b17b3be · b17b3be
1 parent 92e366e
commit b17b3be
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/apps/meteor/app/error-handler/server/lib/RocketChat.ErrorHandler.ts b/apps/meteor/app/error-handler/server/lib/RocketChat.ErrorHandler.ts
@@ -3,14 +3,13 @@ import { Meteor } from 'meteor/meteor';
 
 import { throttledCounter } from '../../../../lib/utils/throttledCounter';
 import { sendMessage } from '../../../lib/server/functions/sendMessage';
-import { notifyOnSettingChanged } from '../../../lib/server/lib/notifyListener';
 import { settings } from '../../../settings/server';
 
 const incException = throttledCounter((counter) => {
 	Settings.incrementValueById('Uncaught_Exceptions_Count', counter, { returnDocument: 'after' })
 		.then(({ value }) => {
 			if (value) {
-				void notifyOnSettingChanged(value);
+				settings.set(value);
 			}
 		})
 		.catch(console.error);
@@ -118,5 +117,12 @@ process.on('unhandledRejection', (error) => {
 
 process.on('uncaughtException', async (error) => {
 	incException();
+
+	console.error('=== UnCaughtException ===');
+	console.error(error);
+	console.error('-------------------------');
+	console.error('Errors like this can cause oplog processing errors.');
+	console.error('===========================');
+
 	void errorHandler.trackError(error.message, error.stack);
 });