fix: `LivechatSessionTaken` webhook event called without `agent` param #33209

KevLehman · 2024-09-04T17:11:53Z

Proposed changes (including videos or screenshots)

Basically, the call to assignAgent was updating the room object as expected, but when calling afterTakeInquiry callback we were passing the room before it was updated.

Issue(s)

https://rocketchat.atlassian.net/browse/SUP-654

Steps to test or reproduce

Further comments

I'm planning to spin up a webhook.test docker image to test this one but probably in the future 😬

dionisio-bot · 2024-09-04T17:11:56Z

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

changeset-bot · 2024-09-04T17:11:57Z

🦋 Changeset detected

Latest commit: 57c126c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 28 packages

Name	Type
@rocket.chat/meteor	Patch
@rocket.chat/core-typings	Patch
@rocket.chat/rest-typings	Patch
@rocket.chat/api-client	Patch
@rocket.chat/apps	Patch
@rocket.chat/core-services	Patch
@rocket.chat/cron	Patch
@rocket.chat/ddp-client	Patch
@rocket.chat/fuselage-ui-kit	Patch
@rocket.chat/gazzodown	Patch
@rocket.chat/livechat	Patch
@rocket.chat/model-typings	Patch
@rocket.chat/ui-contexts	Patch
@rocket.chat/account-service	Patch
@rocket.chat/authorization-service	Patch
@rocket.chat/ddp-streamer	Patch
@rocket.chat/omnichannel-transcript	Patch
@rocket.chat/presence-service	Patch
@rocket.chat/queue-worker	Patch
@rocket.chat/stream-hub-service	Patch
@rocket.chat/license	Patch
@rocket.chat/omnichannel-services	Patch
@rocket.chat/pdf-worker	Patch
@rocket.chat/presence	Patch
rocketchat-services	Patch
@rocket.chat/uikit-playground	Patch
@rocket.chat/models	Patch
@rocket.chat/instance-status	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codecov · 2024-09-04T17:20:17Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.84%. Comparing base (6a3c25c) to head (57c126c).
Report is 1 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #33209      +/-   ##
===========================================
- Coverage    59.85%   59.84%   -0.01%     
===========================================
  Files         2554     2554              
  Lines        63008    63105      +97     
  Branches     14129    14146      +17     
===========================================
+ Hits         37711    37766      +55     
- Misses       22890    22924      +34     
- Partials      2407     2415       +8

Flag	Coverage Δ
unit	`77.14% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

apps/meteor/app/livechat/server/lib/RoutingManager.ts

MarcosSpessatto

~~Is there any way of adding tests?~~ Just saw the description

sophia-devs · 2024-09-17T14:53:20Z

Can we get an update on this?

stale

github-actions · 2024-09-18T17:25:17Z

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-09-18 18:25 UTC

#33209)

…hAvatarById * 'develop' of github.com:RocketChat/Rocket.Chat: feat: Implement proper accessbility for report user modal (#33294) chore: update E2EE setting text (#33226) fix: conference calls are shown as "not answered" after they end (#33179) fix: markdown inconsistency with bold and italics (#33157) feat: E2EE messages mentions (#32510) refactor: Reactions set/unset (#32994) ci: auto candidate releases (#33325) feat: `RoomSidepanel` (#33225) feat: contextualbar based on chat size (#33321) fix: error on sendmessage stub (#33317) fix: `LivechatSessionTaken` webhook event called without `agent` param (#33209) refactor: Remove old `setreaction` callbacks and use new after/before callbacks (#33309) fix: Mark as unread not working (#32939) fix: Local avatars prioritized over external avatar provider and remove remnant references on client of `Accounts_AvatarExternalProviderUrl` (#33296) feat: Allow managing association to business units on departments' creation and update (#32682)

* Bump 6.12.1 * fix: message parser being slow to process very long messages with too many symbols (#33254) Co-authored-by: Pierre Lehnen <55164754+pierre-lehnen-rc@users.noreply.github.com> * fix: Allow to use the token from `room.v` when requesting transcript instead of finding visitor (#33242) Co-authored-by: Kevin Aleman <11577696+KevLehman@users.noreply.github.com> * fix: Retention Policy cached settings not updated during upgrade procedure (#33265) Co-authored-by: gabriellsh <40830821+gabriellsh@users.noreply.github.com> * fix: imported fixes (#33268) Co-authored-by: Julio A. <52619625+julio-cfa@users.noreply.github.com> * Release 6.12.1 [no ci] * fix: Federation callback not awaiting model call (#33298) * fix: correct parameter order in afterSaveMessage to restore outgoing webhooks and related features (#33295) * feat: New endpoint for listing rooms & discussions from teams (#33177) * chore: Update typings on callbacks to accept less than a full room object (#33305) * fix: resolve avatar download issue on setUsername by refining service selection logic (#33193) * feat: Allow managing association to business units on departments' creation and update (#32682) * fix: Local avatars prioritized over external avatar provider and remove remnant references on client of `Accounts_AvatarExternalProviderUrl` (#33296) Co-authored-by: gabriellsh <40830821+gabriellsh@users.noreply.github.com> * fix: Mark as unread not working (#32939) Co-authored-by: Douglas Fabris <27704687+dougfabris@users.noreply.github.com> * refactor: Remove old `setreaction` callbacks and use new after/before callbacks (#33309) * fix: `LivechatSessionTaken` webhook event called without `agent` param (#33209) * fix: error on sendmessage stub (#33317) * feat: contextualbar based on chat size (#33321) * feat: `RoomSidepanel` (#33225) Co-authored-by: Guilherme Gazzo <5263975+ggazzo@users.noreply.github.com> * ci: auto candidate releases (#33325) Co-authored-by: Diego Sampaio <chinello@gmail.com> * refactor: Reactions set/unset (#32994) * feat: E2EE messages mentions (#32510) * fix: markdown inconsistency with bold and italics (#33157) * fix: conference calls are shown as "not answered" after they end (#33179) * Release 6.13.0-rc.0 * chore: update E2EE setting text (#33226) * feat: Implement proper accessbility for report user modal (#33294) Co-authored-by: Tasso Evangelista <2263066+tassoevan@users.noreply.github.com> * fix: imported fixes (#33330) * chore: create network broker package (#33338) * feat: Adds new admin feature preview setting management (#33212) Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com> * chore: move common files to core-services (#33341) * regression: `Sidepanel` color highlight (#33342) * feat: Adds new admin feature preview setting management (#33212) Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com> * fix: Avoid destructuring `connectionData` when value is undefined (#33339) * Release 6.13.0-rc.1 [no ci] * chore: replace Meteor._localStorage -> Accounts.storageLocation (#33356) * Bump rocket.chat to 6.14.0-develop (#33366) * ci: use node20 for release action (#33343) --------- Co-authored-by: rocketchat-github-ci <buildmaster@rocket.chat> Co-authored-by: dionisio-bot[bot] <117394943+dionisio-bot[bot]@users.noreply.github.com> Co-authored-by: Pierre Lehnen <55164754+pierre-lehnen-rc@users.noreply.github.com> Co-authored-by: Kevin Aleman <11577696+KevLehman@users.noreply.github.com> Co-authored-by: gabriellsh <40830821+gabriellsh@users.noreply.github.com> Co-authored-by: Julio A. <52619625+julio-cfa@users.noreply.github.com> Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com> Co-authored-by: Kevin Aleman <kaleman960@gmail.com> Co-authored-by: Ricardo Garim <rswarovsky@gmail.com> Co-authored-by: Matheus Barbosa Silva <36537004+matheusbsilva137@users.noreply.github.com> Co-authored-by: Tasso Evangelista <tasso.evangelista@rocket.chat> Co-authored-by: Martin Schoeler <martin.schoeler@rocket.chat> Co-authored-by: Douglas Fabris <27704687+dougfabris@users.noreply.github.com> Co-authored-by: Júlia Jaeger Foresti <60678893+juliajforesti@users.noreply.github.com> Co-authored-by: Guilherme Gazzo <5263975+ggazzo@users.noreply.github.com> Co-authored-by: Diego Sampaio <chinello@gmail.com> Co-authored-by: Hugo Costa <hugocarreiracosta@gmail.com> Co-authored-by: csuadev <72958726+csuadev@users.noreply.github.com> Co-authored-by: Henrique Guimarães Ribeiro <43561537+rique223@users.noreply.github.com> Co-authored-by: Tasso Evangelista <2263066+tassoevan@users.noreply.github.com> Co-authored-by: Lucas Pelegrino <lucas.pelegrino@icloud.com> Co-authored-by: Trivikram Kamat <16024985+trivikr@users.noreply.github.com>

#33209)

find room before calling aftertakeinquiry

15b585c

Create spicy-rocks-burn.md

f1ce8b6

KevLehman marked this pull request as ready for review September 4, 2024 17:51

KevLehman requested a review from a team as a code owner September 4, 2024 17:51

KevLehman added this to the 6.13 milestone Sep 4, 2024

MarcosSpessatto previously approved these changes Sep 5, 2024

View reviewed changes

ggazzo previously requested changes Sep 5, 2024

View reviewed changes

apps/meteor/app/livechat/server/lib/RoutingManager.ts Outdated Show resolved Hide resolved

Update RoutingManager.ts

c417b3b

KevLehman dismissed MarcosSpessatto’s stale review via c417b3b September 5, 2024 13:42

KevLehman requested review from ggazzo and MarcosSpessatto September 5, 2024 13:42

MarcosSpessatto requested changes Sep 16, 2024

View reviewed changes

MarcosSpessatto approved these changes Sep 16, 2024

View reviewed changes

MartinSchoeler approved these changes Sep 17, 2024

View reviewed changes

jessicaschelly added the stat: QA assured Means it has been tested and approved by a company insider label Sep 18, 2024

dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Sep 18, 2024

Merge branch 'develop' into fix/livechat-session-taken-missing-agent

57c126c

dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Sep 18, 2024

KevLehman added the stat: ready to merge PR tested and approved waiting for merge label Sep 18, 2024

kodiakhq bot merged commit d0595a3 into develop Sep 18, 2024
49 checks passed

kodiakhq bot deleted the fix/livechat-session-taken-missing-agent branch September 18, 2024 18:24

rocketchat-github-ci mentioned this pull request Sep 20, 2024

Release 6.13.0 #33326

Merged

KevLehman added a commit that referenced this pull request Sep 20, 2024

fix: LivechatSessionTaken webhook event called without agent param (

2c2ad3e

#33209)

abhinavkrin pushed a commit that referenced this pull request Oct 25, 2024

fix: LivechatSessionTaken webhook event called without agent param (

ed9b32d

#33209)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: `LivechatSessionTaken` webhook event called without `agent` param #33209

fix: `LivechatSessionTaken` webhook event called without `agent` param #33209

KevLehman commented Sep 4, 2024 •

edited

Loading

dionisio-bot bot commented Sep 4, 2024 •

edited

Loading

changeset-bot bot commented Sep 4, 2024 •

edited

Loading

codecov bot commented Sep 4, 2024 •

edited

Loading

MarcosSpessatto left a comment •

edited

Loading

sophia-devs commented Sep 17, 2024

github-actions bot commented Sep 18, 2024 •

edited

Loading

fix: LivechatSessionTaken webhook event called without agent param #33209

fix: LivechatSessionTaken webhook event called without agent param #33209

Conversation

KevLehman commented Sep 4, 2024 • edited Loading

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

dionisio-bot bot commented Sep 4, 2024 • edited Loading

changeset-bot bot commented Sep 4, 2024 • edited Loading

🦋 Changeset detected

codecov bot commented Sep 4, 2024 • edited Loading

Codecov Report

MarcosSpessatto left a comment • edited Loading

Choose a reason for hiding this comment

sophia-devs commented Sep 17, 2024

github-actions bot commented Sep 18, 2024 • edited Loading

fix: `LivechatSessionTaken` webhook event called without `agent` param #33209

fix: `LivechatSessionTaken` webhook event called without `agent` param #33209

KevLehman commented Sep 4, 2024 •

edited

Loading

dionisio-bot bot commented Sep 4, 2024 •

edited

Loading

changeset-bot bot commented Sep 4, 2024 •

edited

Loading

codecov bot commented Sep 4, 2024 •

edited

Loading

MarcosSpessatto left a comment •

edited

Loading

github-actions bot commented Sep 18, 2024 •

edited

Loading