fix: resolve avatar download issue on setUsername by refining service selection logic #33193

ricardogarim · 2024-09-02T03:14:59Z

As per CORE-650, this pull request addresses the issue where the avatar blob image was not being correctly set in the setUserAvatar method, resulting in an undefined error for the user. The root cause was identified as incorrect handling of avatar service selection, which led to errors during the avatar setting process.

Key changes:

Corrected the service handling logic to ensure the avatar blob is properly set from the first available service.
Enhanced the process to prioritize non-gravatar services while maintaining a fallback to gravatar if no other service is available.

dionisio-bot · 2024-09-02T03:15:03Z

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

changeset-bot · 2024-09-02T03:15:04Z

🦋 Changeset detected

Latest commit: 7a5bb19

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 28 packages

Name	Type
@rocket.chat/meteor	Patch
@rocket.chat/core-typings	Patch
@rocket.chat/rest-typings	Patch
@rocket.chat/api-client	Patch
@rocket.chat/apps	Patch
@rocket.chat/core-services	Patch
@rocket.chat/cron	Patch
@rocket.chat/ddp-client	Patch
@rocket.chat/fuselage-ui-kit	Patch
@rocket.chat/gazzodown	Patch
@rocket.chat/livechat	Patch
@rocket.chat/model-typings	Patch
@rocket.chat/ui-contexts	Patch
@rocket.chat/account-service	Patch
@rocket.chat/authorization-service	Patch
@rocket.chat/ddp-streamer	Patch
@rocket.chat/omnichannel-transcript	Patch
@rocket.chat/presence-service	Patch
@rocket.chat/queue-worker	Patch
@rocket.chat/stream-hub-service	Patch
@rocket.chat/license	Patch
@rocket.chat/omnichannel-services	Patch
@rocket.chat/pdf-worker	Patch
@rocket.chat/presence	Patch
rocketchat-services	Patch
@rocket.chat/uikit-playground	Patch
@rocket.chat/models	Patch
@rocket.chat/instance-status	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codecov · 2024-09-02T03:20:29Z

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 59.74%. Comparing base (f27092b) to head (7a5bb19).
Report is 1 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #33193      +/-   ##
===========================================
+ Coverage    59.70%   59.74%   +0.03%     
===========================================
  Files         2551     2552       +1     
  Lines        62792    62906     +114     
  Branches     14102    14129      +27     
===========================================
+ Hits         37492    37581      +89     
- Misses       22893    22917      +24     
- Partials      2407     2408       +1

Flag	Coverage Δ
unit	`76.96% <85.71%> (+0.05%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

MarcosSpessatto

Is there any way we could add some tests here?

apps/meteor/tests/unit/app/lib/server/functions/setUsername.spec.ts

github-actions · 2024-09-12T13:50:53Z

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-09-17 20:56 UTC

sampaiodiego

for a further optimization, when calling setUsername we don't need to call getAvatarSuggestionForUser which will fetch avatar for EVERY SERVICE available, we just need the first one =)

… selection logic (#33193)

* Bump 6.12.1 * fix: message parser being slow to process very long messages with too many symbols (#33254) Co-authored-by: Pierre Lehnen <55164754+pierre-lehnen-rc@users.noreply.github.com> * fix: Allow to use the token from `room.v` when requesting transcript instead of finding visitor (#33242) Co-authored-by: Kevin Aleman <11577696+KevLehman@users.noreply.github.com> * fix: Retention Policy cached settings not updated during upgrade procedure (#33265) Co-authored-by: gabriellsh <40830821+gabriellsh@users.noreply.github.com> * fix: imported fixes (#33268) Co-authored-by: Julio A. <52619625+julio-cfa@users.noreply.github.com> * Release 6.12.1 [no ci] * fix: Federation callback not awaiting model call (#33298) * fix: correct parameter order in afterSaveMessage to restore outgoing webhooks and related features (#33295) * feat: New endpoint for listing rooms & discussions from teams (#33177) * chore: Update typings on callbacks to accept less than a full room object (#33305) * fix: resolve avatar download issue on setUsername by refining service selection logic (#33193) * feat: Allow managing association to business units on departments' creation and update (#32682) * fix: Local avatars prioritized over external avatar provider and remove remnant references on client of `Accounts_AvatarExternalProviderUrl` (#33296) Co-authored-by: gabriellsh <40830821+gabriellsh@users.noreply.github.com> * fix: Mark as unread not working (#32939) Co-authored-by: Douglas Fabris <27704687+dougfabris@users.noreply.github.com> * refactor: Remove old `setreaction` callbacks and use new after/before callbacks (#33309) * fix: `LivechatSessionTaken` webhook event called without `agent` param (#33209) * fix: error on sendmessage stub (#33317) * feat: contextualbar based on chat size (#33321) * feat: `RoomSidepanel` (#33225) Co-authored-by: Guilherme Gazzo <5263975+ggazzo@users.noreply.github.com> * ci: auto candidate releases (#33325) Co-authored-by: Diego Sampaio <chinello@gmail.com> * refactor: Reactions set/unset (#32994) * feat: E2EE messages mentions (#32510) * fix: markdown inconsistency with bold and italics (#33157) * fix: conference calls are shown as "not answered" after they end (#33179) * Release 6.13.0-rc.0 * chore: update E2EE setting text (#33226) * feat: Implement proper accessbility for report user modal (#33294) Co-authored-by: Tasso Evangelista <2263066+tassoevan@users.noreply.github.com> * fix: imported fixes (#33330) * chore: create network broker package (#33338) * feat: Adds new admin feature preview setting management (#33212) Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com> * chore: move common files to core-services (#33341) * regression: `Sidepanel` color highlight (#33342) * feat: Adds new admin feature preview setting management (#33212) Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com> * fix: Avoid destructuring `connectionData` when value is undefined (#33339) * Release 6.13.0-rc.1 [no ci] * chore: replace Meteor._localStorage -> Accounts.storageLocation (#33356) * Bump rocket.chat to 6.14.0-develop (#33366) * ci: use node20 for release action (#33343) --------- Co-authored-by: rocketchat-github-ci <buildmaster@rocket.chat> Co-authored-by: dionisio-bot[bot] <117394943+dionisio-bot[bot]@users.noreply.github.com> Co-authored-by: Pierre Lehnen <55164754+pierre-lehnen-rc@users.noreply.github.com> Co-authored-by: Kevin Aleman <11577696+KevLehman@users.noreply.github.com> Co-authored-by: gabriellsh <40830821+gabriellsh@users.noreply.github.com> Co-authored-by: Julio A. <52619625+julio-cfa@users.noreply.github.com> Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com> Co-authored-by: Kevin Aleman <kaleman960@gmail.com> Co-authored-by: Ricardo Garim <rswarovsky@gmail.com> Co-authored-by: Matheus Barbosa Silva <36537004+matheusbsilva137@users.noreply.github.com> Co-authored-by: Tasso Evangelista <tasso.evangelista@rocket.chat> Co-authored-by: Martin Schoeler <martin.schoeler@rocket.chat> Co-authored-by: Douglas Fabris <27704687+dougfabris@users.noreply.github.com> Co-authored-by: Júlia Jaeger Foresti <60678893+juliajforesti@users.noreply.github.com> Co-authored-by: Guilherme Gazzo <5263975+ggazzo@users.noreply.github.com> Co-authored-by: Diego Sampaio <chinello@gmail.com> Co-authored-by: Hugo Costa <hugocarreiracosta@gmail.com> Co-authored-by: csuadev <72958726+csuadev@users.noreply.github.com> Co-authored-by: Henrique Guimarães Ribeiro <43561537+rique223@users.noreply.github.com> Co-authored-by: Tasso Evangelista <2263066+tassoevan@users.noreply.github.com> Co-authored-by: Lucas Pelegrino <lucas.pelegrino@icloud.com> Co-authored-by: Trivikram Kamat <16024985+trivikr@users.noreply.github.com>

… selection logic (#33193)

fix: resolve avatar download issue by refining service selection logic

9e5aea6

chore: add changeset for avatar blob fix

6103815

ricardogarim marked this pull request as ready for review September 2, 2024 11:25

ricardogarim requested a review from a team September 2, 2024 11:25

ricardogarim added the stat: needs testing label Sep 2, 2024

MarcosSpessatto added this to the 6.13 milestone Sep 3, 2024

MarcosSpessatto requested changes Sep 3, 2024

View reviewed changes

ricardogarim added 2 commits September 4, 2024 20:46

test: add unit tests to setUsername

2951e7a

test: add unit tests to setUsername

550232f

ricardogarim requested a review from MarcosSpessatto September 5, 2024 11:40

MarcosSpessatto requested changes Sep 9, 2024

View reviewed changes

apps/meteor/tests/unit/app/lib/server/functions/setUsername.spec.ts Show resolved Hide resolved

test: add previousUsername validations

8ad8502

ricardogarim requested a review from MarcosSpessatto September 12, 2024 11:20

Merge branch 'develop' into fix/download-avatar-image-on-set-username

bd2bf0d

MarcosSpessatto approved these changes Sep 12, 2024

View reviewed changes

sampaiodiego approved these changes Sep 16, 2024

View reviewed changes

jessicaschelly added stat: QA assured Means it has been tested and approved by a company insider and removed stat: needs testing labels Sep 17, 2024

dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Sep 17, 2024

kodiakhq bot added 3 commits September 17, 2024 15:25

Merge branch 'develop' into fix/download-avatar-image-on-set-username

a19d81e

Merge branch 'develop' into fix/download-avatar-image-on-set-username

36c3f4a

Merge branch 'develop' into fix/download-avatar-image-on-set-username

7a5bb19

kodiakhq bot merged commit 4202d65 into develop Sep 17, 2024
50 checks passed

kodiakhq bot deleted the fix/download-avatar-image-on-set-username branch September 17, 2024 20:56

rocketchat-github-ci mentioned this pull request Sep 20, 2024

Release 6.13.0 #33326

Merged

KevLehman pushed a commit that referenced this pull request Sep 20, 2024

fix: resolve avatar download issue on setUsername by refining service…

0dbd88d

… selection logic (#33193)

abhinavkrin pushed a commit that referenced this pull request Oct 25, 2024

fix: resolve avatar download issue on setUsername by refining service…

e9e8ae3

… selection logic (#33193)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: resolve avatar download issue on setUsername by refining service selection logic #33193

fix: resolve avatar download issue on setUsername by refining service selection logic #33193

ricardogarim commented Sep 2, 2024 •

edited by jira bot

Loading

dionisio-bot bot commented Sep 2, 2024 •

edited

Loading

changeset-bot bot commented Sep 2, 2024 •

edited

Loading

codecov bot commented Sep 2, 2024 •

edited

Loading

MarcosSpessatto left a comment

github-actions bot commented Sep 12, 2024 •

edited

Loading

sampaiodiego left a comment

fix: resolve avatar download issue on setUsername by refining service selection logic #33193

fix: resolve avatar download issue on setUsername by refining service selection logic #33193

Conversation

ricardogarim commented Sep 2, 2024 • edited by jira bot Loading

dionisio-bot bot commented Sep 2, 2024 • edited Loading

changeset-bot bot commented Sep 2, 2024 • edited Loading

🦋 Changeset detected

codecov bot commented Sep 2, 2024 • edited Loading

Codecov Report

MarcosSpessatto left a comment

Choose a reason for hiding this comment

github-actions bot commented Sep 12, 2024 • edited Loading

sampaiodiego left a comment

Choose a reason for hiding this comment

ricardogarim commented Sep 2, 2024 •

edited by jira bot

Loading

dionisio-bot bot commented Sep 2, 2024 •

edited

Loading

changeset-bot bot commented Sep 2, 2024 •

edited

Loading

codecov bot commented Sep 2, 2024 •

edited

Loading

github-actions bot commented Sep 12, 2024 •

edited

Loading