-
Notifications
You must be signed in to change notification settings - Fork 10.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: "Forgot Password" e-mail is not translated correctly #32212
fix!: "Forgot Password" e-mail is not translated correctly #32212
Conversation
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: e8dcd3c The changes in this PR will be included in the next version bump. This PR includes changesets to release 33 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-7.0.0 #32212 +/- ##
================================================
Coverage ? 75.69%
================================================
Files ? 430
Lines ? 19893
Branches ? 5078
================================================
Hits ? 15059
Misses ? 4264
Partials ? 570
Flags with carried forward coverage won't be shown. Click here to find out more. |
The base branch was changed.
472825d
to
68fee68
Compare
495a17e
to
a3e9e9b
Compare
ea82dad
to
7e69ab1
Compare
bc4fad7
to
b484993
Compare
* feat: New empty state for upgrading private Apps * chore: Change Marketplace info modal text (#33239) * feat: New tooltips and color behavior for private apps bar (#33243) * feat: New tooltips and behavior for private apps bar * Create brown-pants-press.md * feat: new modal on Private Apps install (#33275) * feat: new modal on Private Apps install * add more variations * Create eleven-rockets-hug.md * chore: change grandfathered modal text (#33291) * chore: Use apps provider to check maxPrivateApps * fix: adds minor fixes to UI and changes requested on review * Update changeset * Replace negative boolean * Refactor `AppsUsageCard` * Add unit test for `AppsUsageCard` * Add unit test for `PrivateEmptyState` * Add unit test for `EnabledAppsCount` * Move tooltip logic away from `useAppsCountQuery` --------- Co-authored-by: Lucas Pelegrino <lucas.pelegrino@icloud.com> Co-authored-by: Tasso <tasso.evangelista@rocket.chat>
Co-authored-by: Marcos Spessatto Defendi <marcos.defendi@rocket.chat>
b98bec3
to
d6bbea8
Compare
* fix: Update translation key used by 'Forgot Password' e-mail body setting --------- Co-authored-by: Marcos Spessatto Defendi <marcos.defendi@rocket.chat>
* fix: Update translation key used by 'Forgot Password' e-mail body setting --------- Co-authored-by: Marcos Spessatto Defendi <marcos.defendi@rocket.chat>
* fix: Update translation key used by 'Forgot Password' e-mail body setting --------- Co-authored-by: Marcos Spessatto Defendi <marcos.defendi@rocket.chat>
* fix: Update translation key used by 'Forgot Password' e-mail body setting --------- Co-authored-by: Marcos Spessatto Defendi <marcos.defendi@rocket.chat>
* fix: Update translation key used by 'Forgot Password' e-mail body setting --------- Co-authored-by: Marcos Spessatto Defendi <marcos.defendi@rocket.chat>
* fix: Update translation key used by 'Forgot Password' e-mail body setting --------- Co-authored-by: Marcos Spessatto Defendi <marcos.defendi@rocket.chat>
* fix: Update translation key used by 'Forgot Password' e-mail body setting --------- Co-authored-by: Marcos Spessatto Defendi <marcos.defendi@rocket.chat>
* fix: Update translation key used by 'Forgot Password' e-mail body setting --------- Co-authored-by: Marcos Spessatto Defendi <marcos.defendi@rocket.chat>
* fix: Update translation key used by 'Forgot Password' e-mail body setting --------- Co-authored-by: Marcos Spessatto Defendi <marcos.defendi@rocket.chat>
* fix: Update translation key used by 'Forgot Password' e-mail body setting --------- Co-authored-by: Marcos Spessatto Defendi <marcos.defendi@rocket.chat>
* fix: Update translation key used by 'Forgot Password' e-mail body setting --------- Co-authored-by: Marcos Spessatto Defendi <marcos.defendi@rocket.chat>
* fix: Update translation key used by 'Forgot Password' e-mail body setting --------- Co-authored-by: Marcos Spessatto Defendi <marcos.defendi@rocket.chat>
Proposed changes (including videos or screenshots)
Forgot_Password_Email
setting.Issue(s)
Introduced by #31343
Steps to test or reproduce
Start a workspace on 6.5 (or an older version), then update to the latest RC version. Then, check the e-mail received when triggering the "forgot password" flow.
Current behavior: the e-mail contains the text
Lets_get_you_new_one
(not correctly translated key).Expected behavior: the e-mail should contain a translated text (such as "Let's get you a new one!") instead of a key.
Further comments
CORE-247