chore: change grandfathered modal text #33291

MartinSchoeler · 2024-09-16T12:13:16Z

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

dionisio-bot · 2024-09-16T12:13:19Z

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

changeset-bot · 2024-09-16T12:13:21Z

⚠️ No Changeset found

Latest commit: 5bcb0d1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions · 2024-09-16T12:19:01Z

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-09-18 16:57 UTC

codecov · 2024-09-16T12:34:46Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.91%. Comparing base (abe1570) to head (5bcb0d1).
Report is 14 commits behind head on unsuported-marketplace.

Additional details and impacted files

@@                   Coverage Diff                   @@
##           unsuported-marketplace   #33291   +/-   ##
=======================================================
  Coverage                   76.91%   76.91%           
=======================================================
  Files                         378      378           
  Lines                       19035    19035           
  Branches                     4905     4905           
=======================================================
  Hits                        14640    14640           
  Misses                       4168     4168           
  Partials                      227      227

Flag	Coverage Δ
unit	`76.91% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

* feat: New empty state for upgrading private Apps * chore: Change Marketplace info modal text (#33239) * feat: New tooltips and color behavior for private apps bar (#33243) * feat: New tooltips and behavior for private apps bar * Create brown-pants-press.md * feat: new modal on Private Apps install (#33275) * feat: new modal on Private Apps install * add more variations * Create eleven-rockets-hug.md * chore: change grandfathered modal text (#33291) * chore: Use apps provider to check maxPrivateApps * fix: adds minor fixes to UI and changes requested on review * Update changeset * Replace negative boolean * Refactor `AppsUsageCard` * Add unit test for `AppsUsageCard` * Add unit test for `PrivateEmptyState` * Add unit test for `EnabledAppsCount` * Move tooltip logic away from `useAppsCountQuery` --------- Co-authored-by: Lucas Pelegrino <lucas.pelegrino@icloud.com> Co-authored-by: Tasso <tasso.evangelista@rocket.chat>

chore: change grandfathered modal text

a8a7b1f

MartinSchoeler added this to the 7.0 milestone Sep 16, 2024

MartinSchoeler marked this pull request as ready for review September 17, 2024 16:45

MartinSchoeler requested a review from a team as a code owner September 17, 2024 16:45

tiagoevanp approved these changes Sep 17, 2024

View reviewed changes

Merge branch 'release-7.0.0' into grandfathered-apps-text-change

5bcb0d1

MartinSchoeler added the stat: QA assured Means it has been tested and approved by a company insider label Sep 17, 2024

dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Sep 17, 2024

MartinSchoeler changed the base branch from release-7.0.0 to unsuported-marketplace September 18, 2024 16:56

MartinSchoeler merged commit db5e722 into unsuported-marketplace Sep 18, 2024
58 checks passed

MartinSchoeler deleted the grandfathered-apps-text-change branch September 18, 2024 16:57

MartinSchoeler added a commit that referenced this pull request Sep 18, 2024

chore: change grandfathered modal text (#33291)

12d8129

MartinSchoeler added a commit that referenced this pull request Sep 18, 2024

chore: change grandfathered modal text (#33291)

6fe47db

MartinSchoeler added a commit that referenced this pull request Sep 18, 2024

chore: change grandfathered modal text (#33291)

a74fa33

MartinSchoeler added a commit that referenced this pull request Sep 18, 2024

chore: change grandfathered modal text (#33291)

c78c9b5

MartinSchoeler removed this from the 7.0 milestone Sep 19, 2024

tassoevan pushed a commit that referenced this pull request Sep 30, 2024

chore: change grandfathered modal text (#33291)

c9de433

tassoevan pushed a commit that referenced this pull request Oct 1, 2024

chore: change grandfathered modal text (#33291)

d68e48a

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: change grandfathered modal text #33291

chore: change grandfathered modal text #33291

MartinSchoeler commented Sep 16, 2024

dionisio-bot bot commented Sep 16, 2024 •

edited

Loading

changeset-bot bot commented Sep 16, 2024 •

edited

Loading

github-actions bot commented Sep 16, 2024 •

edited

Loading

codecov bot commented Sep 16, 2024 •

edited

Loading

chore: change grandfathered modal text #33291

chore: change grandfathered modal text #33291

Conversation

MartinSchoeler commented Sep 16, 2024

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

dionisio-bot bot commented Sep 16, 2024 • edited Loading

changeset-bot bot commented Sep 16, 2024 • edited Loading

⚠️ No Changeset found

github-actions bot commented Sep 16, 2024 • edited Loading

codecov bot commented Sep 16, 2024 • edited Loading

Codecov Report

dionisio-bot bot commented Sep 16, 2024 •

edited

Loading

changeset-bot bot commented Sep 16, 2024 •

edited

Loading

github-actions bot commented Sep 16, 2024 •

edited

Loading

codecov bot commented Sep 16, 2024 •

edited

Loading