Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: internalize flow-router (from meteor 3 branch) #31365

Merged
merged 3 commits into from
Jan 10, 2024

Conversation

MarcosSpessatto
Copy link
Member

@MarcosSpessatto MarcosSpessatto commented Jan 3, 2024

Extracted from #29112

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Copy link

changeset-bot bot commented Jan 3, 2024

⚠️ No Changeset found

Latest commit: 69cb1b7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c93e189) 59.85% compared to head (69cb1b7) 49.56%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop   #31365       +/-   ##
============================================
- Coverage    59.85%   49.56%   -10.30%     
============================================
  Files         1795     3312     +1517     
  Lines        34921    81385    +46464     
  Branches      7275    16698     +9423     
============================================
+ Hits         20901    40336    +19435     
- Misses       12415    36341    +23926     
- Partials      1605     4708     +3103     
Flag Coverage Δ
e2e 53.16% <ø> (-0.01%) ⬇️
e2e-api 40.67% <ø> (?)
unit 76.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Jan 10, 2024
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Jan 10, 2024
@kodiakhq kodiakhq bot merged commit 5845014 into develop Jan 10, 2024
44 of 45 checks passed
@kodiakhq kodiakhq bot deleted the chore/meteor-3-changes-1 branch January 10, 2024 16:17
gabriellsh added a commit that referenced this pull request Jan 10, 2024
…ve/Notifications

* 'develop' of github.com:RocketChat/Rocket.Chat:
  refactor(i18n): Translation's lint and load (#31343)
  fix: multiple indexes creations during migrations (#31413)
  feat: add `ImageGallery` zoom controls (#31369)
  chore: internalize flow-router (from meteor 3 branch) (#31365)
  chore: internalize meteor run as user (from meteor 3) (#31370)
  chore: internalize meteor inject initial (from meteor 3) (#31367)
  chore: internalize meteor cookies (from meteor 3) (#31366)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants