-
Notifications
You must be signed in to change notification settings - Fork 10.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Meteor 3 / NodeJS 18 upgrade #29112
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apps/meteor/packages/rocketchat-tap-i18n/lib/tap_i18next/tap_i18next-1.7.3.js
Fixed
Show fixed
Hide fixed
# Conflicts: # apps/meteor/app/integrations/server/api/api.js
# Conflicts: # apps/meteor/package.json # yarn.lock
# Conflicts: # apps/meteor/.meteor/packages # apps/meteor/client/startup/startup.ts
apps/meteor/packages/meteor-inject-initial/lib/inject-server.js
Dismissed
Show dismissed
Hide dismissed
apps/meteor/packages/meteor-inject-initial/lib/inject-server.js
Dismissed
Show dismissed
Hide dismissed
apps/meteor/packages/meteor-inject-initial/lib/inject-server.js
Dismissed
Show dismissed
Hide dismissed
This was referenced Jan 3, 2024
This was referenced Jan 4, 2024
Merged
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
It finally happened |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments