fix: Changed contact form async validations to onSubmit #29250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #29250 +/- ##
===========================================
- Coverage 46.67% 46.25% -0.42%
===========================================
Files 697 678 -19
Lines 13055 12728 -327
Branches 2223 2216 -7
===========================================
- Hits 6093 5887 -206
+ Misses 6647 6520 -127
- Partials 315 321 +6
Flags with carried forward coverage won't be shown. Click here to find out more. |
KevLehman
previously approved these changes
May 23, 2023
aleksandernsilva
changed the title
🦋 Changeset detectedLatest commit: 6b993e0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 24 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…ocket.Chat into fix/contact-form-validation
KevLehman
previously approved these changes
May 25, 2023
dionisio-bot
bot
added
stat: ready to merge
KevLehman
approved these changes
May 26, 2023
MartinSchoeler
approved these changes
May 26, 2023
KevLehman
removed
the
stat: ready to merge
dionisio-bot
bot
added
the
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
gabriellsh
added a commit
that referenced
this pull request
May 26, 2023
…ove/mentions * 'develop' of github.com:RocketChat/Rocket.Chat: (48 commits) fix: Changed contact form async validations to onSubmit (#29250) refactor: Omnichannel Department re-write (#28948) feat: Added attachments to contact history message list (#29336) fix: Clicking uploaded file title replaces current tab (#29174) fix: broken error messages on room.saveInfo & missing CF validations on omni/contact api (#28367) regression: Missing loading indicator (#29374) fix: Added check if count is truthy on `cleanRoomHistory` (#28081) chore: small tricks with keys and invalidations with marketplace page (#29369) fix: Missing await on agent leave action (#29358) refactor: useQuery for Marketplace Lists (#29348) test: add missing omnichannel contact-center tests (#28989) ci: omit vite log (#29360) chore: update `status-warning-2` color (#29321) fix: File upload in Safari, IOS devices (#27121) chore: update status-bullet colors (#29316) chore: `Contextualbar` empty state consistency (#29341) chore(deps-dev): Bump @storybook/source-loader from 6.5.15 to 6.5.16 (#27866) feat(apps): Disabling apps on trial license expiration (#29037) chore(deps-dev): Bump @storybook/manager-webpack4 from 6.5.15 to 6.5.16 (#27865) chore(deps-dev): Bump @storybook/addon-actions from 6.5.15 to 6.5.16 (#27917) ...
gabriellsh
added a commit
that referenced
this pull request
May 26, 2023
…memberList * 'develop' of github.com:RocketChat/Rocket.Chat: (30 commits) fix: Changed contact form async validations to onSubmit (#29250) refactor: Omnichannel Department re-write (#28948) feat: Added attachments to contact history message list (#29336) fix: Clicking uploaded file title replaces current tab (#29174) fix: broken error messages on room.saveInfo & missing CF validations on omni/contact api (#28367) regression: Missing loading indicator (#29374) fix: Added check if count is truthy on `cleanRoomHistory` (#28081) chore: small tricks with keys and invalidations with marketplace page (#29369) fix: Missing await on agent leave action (#29358) refactor: useQuery for Marketplace Lists (#29348) test: add missing omnichannel contact-center tests (#28989) ci: omit vite log (#29360) chore: update `status-warning-2` color (#29321) fix: File upload in Safari, IOS devices (#27121) chore: update status-bullet colors (#29316) chore: `Contextualbar` empty state consistency (#29341) chore(deps-dev): Bump @storybook/source-loader from 6.5.15 to 6.5.16 (#27866) feat(apps): Disabling apps on trial license expiration (#29037) chore(deps-dev): Bump @storybook/manager-webpack4 from 6.5.15 to 6.5.16 (#27865) chore(deps-dev): Bump @storybook/addon-actions from 6.5.15 to 6.5.16 (#27917) ...
hugocostadev
pushed a commit
that referenced
this pull request
May 30, 2023
Co-authored-by: Kevin Aleman <11577696+KevLehman@users.noreply.github.com>
This was referenced May 31, 2023
This was referenced Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
This PR fixes a situation where all required fields of the form were filled but the save button is still disabled. The cause was due to a few async validations that required a complicated combination of onSubmit and onChange validations.
The solution is running the async validations only on submit to simplify the logic.
Issue(s)
OC-697
OC-144
Steps to test or reproduce
Further comments