Skip to content

Conversation

@tassoevan
Copy link
Contributor

@tassoevan tassoevan commented Apr 24, 2023

Proposed changes (including videos or screenshots)

When the license expires, the apps will be disabled!

Issue(s)

Steps to test or reproduce

Further comments

AECO-59

@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

❗ No coverage uploaded for pull request base (develop@c58c91c). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop   #29037   +/-   ##
==========================================
  Coverage           ?   45.67%           
==========================================
  Files              ?      702           
  Lines              ?    13111           
  Branches           ?     2216           
==========================================
  Hits               ?     5989           
  Misses             ?     6820           
  Partials           ?      302           
Flag Coverage Δ
e2e 45.64% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@tiagoevanp tiagoevanp marked this pull request as ready for review April 27, 2023 13:02
@tiagoevanp tiagoevanp added this to the 6.3.0 milestone Apr 27, 2023
@casalsgh casalsgh requested review from AllanPazRibeiro, csuadev and sampaiodiego and removed request for sampaiodiego May 17, 2023 18:42
Copy link
Contributor

@AllanPazRibeiro AllanPazRibeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@changeset-bot
Copy link

changeset-bot bot commented May 18, 2023

⚠️ No Changeset found

Latest commit: cb12b20

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label May 24, 2023
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label May 24, 2023
@tiagoevanp tiagoevanp added the stat: ready to merge PR tested and approved waiting for merge label May 24, 2023
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label May 24, 2023
@tiagoevanp tiagoevanp added the stat: ready to merge PR tested and approved waiting for merge label May 24, 2023
@kodiakhq kodiakhq bot merged commit bcde1b9 into develop May 24, 2023
@kodiakhq kodiakhq bot deleted the feat/disable-apps-on-trial-expiration branch May 24, 2023 19:29
gabriellsh added a commit that referenced this pull request May 26, 2023
…ove/mentions

* 'develop' of github.com:RocketChat/Rocket.Chat: (48 commits)
  fix: Changed contact form async validations to onSubmit (#29250)
  refactor: Omnichannel Department re-write (#28948)
  feat: Added attachments to contact history message list (#29336)
  fix: Clicking uploaded file title replaces current tab (#29174)
  fix: broken error messages on room.saveInfo & missing CF validations on omni/contact api (#28367)
  regression: Missing loading indicator (#29374)
  fix: Added check if count is truthy on `cleanRoomHistory` (#28081)
  chore: small tricks with keys and invalidations with marketplace page (#29369)
  fix: Missing await on agent leave action (#29358)
  refactor: useQuery for Marketplace Lists (#29348)
  test: add missing omnichannel contact-center tests (#28989)
  ci: omit vite log (#29360)
  chore: update `status-warning-2` color (#29321)
  fix: File upload in Safari, IOS devices (#27121)
  chore: update status-bullet colors (#29316)
  chore: `Contextualbar` empty state consistency (#29341)
  chore(deps-dev): Bump @storybook/source-loader from 6.5.15 to 6.5.16 (#27866)
  feat(apps): Disabling apps on trial license expiration (#29037)
  chore(deps-dev): Bump @storybook/manager-webpack4 from 6.5.15 to 6.5.16 (#27865)
  chore(deps-dev): Bump @storybook/addon-actions from 6.5.15 to 6.5.16 (#27917)
  ...
gabriellsh added a commit that referenced this pull request May 26, 2023
…memberList

* 'develop' of github.com:RocketChat/Rocket.Chat: (30 commits)
  fix: Changed contact form async validations to onSubmit (#29250)
  refactor: Omnichannel Department re-write (#28948)
  feat: Added attachments to contact history message list (#29336)
  fix: Clicking uploaded file title replaces current tab (#29174)
  fix: broken error messages on room.saveInfo & missing CF validations on omni/contact api (#28367)
  regression: Missing loading indicator (#29374)
  fix: Added check if count is truthy on `cleanRoomHistory` (#28081)
  chore: small tricks with keys and invalidations with marketplace page (#29369)
  fix: Missing await on agent leave action (#29358)
  refactor: useQuery for Marketplace Lists (#29348)
  test: add missing omnichannel contact-center tests (#28989)
  ci: omit vite log (#29360)
  chore: update `status-warning-2` color (#29321)
  fix: File upload in Safari, IOS devices (#27121)
  chore: update status-bullet colors (#29316)
  chore: `Contextualbar` empty state consistency (#29341)
  chore(deps-dev): Bump @storybook/source-loader from 6.5.15 to 6.5.16 (#27866)
  feat(apps): Disabling apps on trial license expiration (#29037)
  chore(deps-dev): Bump @storybook/manager-webpack4 from 6.5.15 to 6.5.16 (#27865)
  chore(deps-dev): Bump @storybook/addon-actions from 6.5.15 to 6.5.16 (#27917)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants