Regression: Matrix Federation regressions #26283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
July 18, 2022 08:48
…nto feat/federation
… federated rooms (#26263) * fix: do not allow non-owners edit or add users on federated rooms * fix: do not allow non-owners to remove users from federated rooms * fix: apply suggestion from review
added 2 commits
July 18, 2022 11:20
… federated rooms (#26263) * fix: do not allow non-owners edit or add users on federated rooms * fix: do not allow non-owners to remove users from federated rooms * fix: apply suggestion from review
added 2 commits
July 18, 2022 14:38
sampaiodiego
requested changes
Jul 18, 2022
gabriellsh
requested changes
Jul 19, 2022
apps/meteor/app/federation-v2/server/infrastructure/rocket-chat/Federation.ts
Show resolved
Hide resolved
apps/meteor/app/federation-v2/server/infrastructure/rocket-chat/Federation.ts
Show resolved
Hide resolved
sampaiodiego
requested changes
Jul 19, 2022
sampaiodiego
approved these changes
Jul 19, 2022
Member
sampaiodiego
left a comment
sampaiodiego
left a comment
There was a problem hiding this comment.
not sure what happened since last commit, lots of files removed.
anyways, looking forward for the type casting removals, as right now they feel very loose.
ggazzo
added
stat: ready to merge
Contributor
|
QA Tested. Bug found for a minor item and we'll proceed with known issue. |
casalsgh
added
stat: needs QA
stat: ready to merge
ggazzo
added
stat: needs QA
stat: ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments