Regression: Do not allow non-owners edit rooms or add/remove users on federated rooms

[MarcosSpessatto]

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

[sampaiodiego]

I added some comments, but I was thinking about the root cause of the issue.. maybe I need an explanation what the issue is 😬

because in theory only the room owner or an admin will have the permission to edit a room already.. maybe in case of a federated room there will be no subscription (do they have subscriptions?), so the owner check would fail, but for admin it not fail.. 🤔

[MarcosSpessatto]

I added some comments, but I was thinking about the root cause of the issue.. maybe I need an explanation what the issue is 😬

because in theory only the room owner or an admin will have the permission to edit a room already.. maybe in case of a federated room there will be no subscription (do they have subscriptions?), so the owner check would fail, but for admin it not fail.. 🤔

Good point, so the first answer is: yes, they do have subscriptions, it's at the end of the day, a regular rocket.chat room, there's even no specific type to describe it, it's using the same as we use today (p, c, d, etc).

Also, in the case of the federated rooms, even the admins should now be able to edit that, I mean, for now, until we do not support any kind of permission/role from the Matrix side, we must allow only and only the owner to edit the things.