Skip to content

[IMPROVE] System messages' consistency #26130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kodiakhq merged 17 commits into from
Sep 6, 2022
Merged

[IMPROVE] System messages' consistency #26130

kodiakhq merged 17 commits into from
Sep 6, 2022

Conversation

@matheusbsilva137
Copy link
Contributor

@matheusbsilva137 matheusbsilva137 commented Jul 5, 2022

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@matheusbsilva137 matheusbsilva137 mentioned this pull request Jul 15, 2022
Closed
@alvaropmello alvaropmello added this to the 5.1.0 milestone Jul 21, 2022
@codecov
Copy link

codecov bot commented Aug 11, 2022 •
edited
Loading

Codecov Report

Merging #26130 (99bd4dd) into develop (01c8786) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #26130      +/-   ##
===========================================
+ Coverage    40.54%   40.55%   +0.01%     
===========================================
  Files          799      799              
  Lines        18296    18286      -10     
  Branches      1954     1954              
===========================================
- Hits          7418     7416       -2     
+ Misses       10583    10571      -12     
- Partials       295      299       +4
Flag Coverage Δ
e2e 40.55% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

dnlsilva
dnlsilva reviewed Aug 15, 2022
View reviewed changes
@ggazzo ggazzo requested a review from a team as a code owner August 16, 2022 13:11
sampaiodiego
sampaiodiego previously requested changes Aug 16, 2022
View reviewed changes
Copy link
Member

@sampaiodiego sampaiodiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see a lot of translations where a variable has been removed, but the code is still providing them. For those cases I'd recommend creating a new string, because other languages will be incorrect anyways. The code also needs to be updated.

@LucianoPierdona LucianoPierdona requested a review from a team as a code owner August 22, 2022 12:43
@LucianoPierdona LucianoPierdona requested a review from a team as a code owner August 22, 2022 14:23
hugocostadev
hugocostadev previously requested changes Aug 22, 2022
View reviewed changes
Copy link
Contributor

@hugocostadev hugocostadev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there, @LucianoPierdona could you please remove all font-styles from system-messages ? E.g: <em></em> and etc...

There are a task to remove those, if you add will be confusing in some cases. Thanks

gabriellsh
gabriellsh previously approved these changes Aug 22, 2022
View reviewed changes
Copy link
Member

@gabriellsh gabriellsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's wait for QA and we can merge.

@gabriellsh gabriellsh removed this from the 5.1.0 milestone Aug 22, 2022
dnlsilva
dnlsilva reviewed Aug 23, 2022
View reviewed changes
@dnlsilva dnlsilva mentioned this pull request Aug 23, 2022
Merged
10 tasks
@LucianoPierdona @dnlsilva
Update apps/meteor/packages/rocketchat-i18n/i18n/en.i18n.json
5fe391d 
Co-authored-by: Gleidson Daniel Silva <gleidson10daniel@hotmail.com>
@ggazzo ggazzo added the stat: ready to merge PR tested and approved waiting for merge label Aug 31, 2022
@gabriellsh gabriellsh dismissed stale reviews from hugocostadev and sampaiodiego September 5, 2022 12:46

Fixed

@kodiakhq kodiakhq bot merged commit 02d5f70 into develop Sep 6, 2022
@kodiakhq kodiakhq bot deleted the improve/sys-messages branch September 6, 2022 18:12
@alvaropmello alvaropmello added this to the 5.2.0 milestone Sep 21, 2022
@tassoevan tassoevan mentioned this pull request Oct 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@diegolmello diegolmello diegolmello left review comments

@gabriellsh gabriellsh gabriellsh approved these changes

@sampaiodiego sampaiodiego Awaiting requested review from sampaiodiego

+4 more reviewers

@dnlsilva dnlsilva dnlsilva left review comments

@LucianoPierdona LucianoPierdona LucianoPierdona left review comments

@tiagoevanp tiagoevanp tiagoevanp approved these changes

@hugocostadev hugocostadev hugocostadev left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

squad: team-collab stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Milestone

5.2.0

Development

Successfully merging this pull request may close these issues.