[IMPROVE] Enhance the changed_room_privacy system message text
#24865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ostjen
previously approved these changes
Mar 24, 2022
pierre-lehnen-rc
previously approved these changes
Apr 18, 2022
…ove/teams-sys-mes-privacy * 'develop' of github.com:RocketChat/Rocket.Chat: (225 commits) Regression: Rocket.Chat Webapp not loading. (#25349) Regression: Fix multi line is not showing an empty line between lines (#25317) Regression: bump onboarding-ui version (#25320) Chore: Create README.md for Rest Typings (#25335) Regression: Parser message when notify ephemeral message Regression: Messages in new message template Crashing. (#25327) Regression: Better MongoDB connection management for micro services (#25323) Regression: Validate empty fields for Message template (#25250) Regression: Fix the alpine image and dev UX installing matrix-rust-sdk-bindings (#25319) Regression: Change preference to be default legacy messages (#25255) Regression: Fix reply button not working when hideFlexTab is enabled (#25306) Regression: Add eslint package to micro services Dockerfile (#25311) Chore: ensure scripts use cross-env and ignore some dirs (ROC-54) (#25218) Regression: Revert Bugsnag version (#25313) Regression: eslint not running on packages (#25305) Update CODEOWNERS Regression: Add isPending status to message (#25299) Regression: Shows error if micro service cannot connect to Mongo (#25301) Regression: Use exact Node version on micro services Docker images (#25287) Chore: Add root package.json to houston files (#25286) ...
Contributor
Author
|
Changes applied in #26130 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
changed_room_privacysystem message text to "@user changed room to public" or "@user changed room to private"Issue(s)
Steps to test or reproduce
Create a team, go to Team's Information > Edit > Private, toggle this option and save. A system message should be sent in the team's main room.
Further comments