Skip to content

[FIX] Modal freezing app after return from the background#4795

Merged
reinaldonetof merged 2 commits intodevelopfrom
fix.modal-freezing-ios-app
Jan 9, 2023
Merged

[FIX] Modal freezing app after return from the background#4795
reinaldonetof merged 2 commits intodevelopfrom
fix.modal-freezing-ios-app

Conversation

@reinaldonetof
Copy link
Contributor

@reinaldonetof reinaldonetof commented Jan 4, 2023

Proposed changes

This issue was found the first time when the user opened the announcement and the announcement's text is a link. Then the user pressed the link and should open the web browser outside of the app. This behavior was forcing the app to go to the background, then when the user resume the app again and tried to close the modal, the app was freezing.

During some tests, I noticed that is only happening on iOS and we still need to keep the list.query to resolve this bug that still occurs on Android #1410

Issue(s)

How to test or reproduce

You need to test properly for iOS and Android

1 - For both, open the announcement inside any Room
2 - Then, minimize the app or if the announcement is a link, click on it
3 - After the app goes to background, resume it again
4 - You should be able to dismiss the announcement modal
5 - Then, after dismissing the announcement, do a long press in any message, the actions will open
6 - Click to Share, and use the Rocket.Chat to share it, share the message to any room
7 - Then, back again to the app, you should be in the same room as before and be able to send and receive messages, and the message list must be refreshing correctly

The steps from 5 - 7 you can compare them with this Issue #1408

We are testing this, to avoid any regression.

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

TC-340

Copy link
Member

@diegolmello diegolmello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm only missing a clear test plan so we don't have a regression to #1410

@reinaldonetof reinaldonetof merged commit 9525ef2 into develop Jan 9, 2023
@reinaldonetof reinaldonetof deleted the fix.modal-freezing-ios-app branch January 9, 2023 18:32
ivnxyz pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants