[FIX] Modal freezing app after return from the background#4795
Merged
reinaldonetof merged 2 commits intodevelopfrom Jan 9, 2023
Merged
[FIX] Modal freezing app after return from the background#4795reinaldonetof merged 2 commits intodevelopfrom
reinaldonetof merged 2 commits intodevelopfrom
Conversation
10 tasks
diegolmello
approved these changes
Jan 5, 2023
Member
diegolmello
left a comment
There was a problem hiding this comment.
I'm only missing a clear test plan so we don't have a regression to #1410
diegolmello
pushed a commit
that referenced
this pull request
Jan 24, 2023
ivnxyz
pushed a commit
to NextiaDev/Rocket.Chat.ReactNative
that referenced
this pull request
May 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This issue was found the first time when the user opened the announcement and the announcement's text is a link. Then the user pressed the link and should open the web browser outside of the app. This behavior was forcing the app to go to the background, then when the user resume the app again and tried to close the modal, the app was freezing.
During some tests, I noticed that is only happening on iOS and we still need to keep the
list.queryto resolve this bug that still occurs on Android #1410Issue(s)
How to test or reproduce
You need to test properly for iOS and Android
1 - For both, open the announcement inside any Room
2 - Then, minimize the app or if the announcement is a link, click on it
3 - After the app goes to background, resume it again
4 - You should be able to dismiss the announcement modal
5 - Then, after dismissing the announcement, do a long press in any message, the actions will open
6 - Click to Share, and use the Rocket.Chat to share it, share the message to any room
7 - Then, back again to the app, you should be in the same room as before and be able to send and receive messages, and the message list must be refreshing correctly
The steps from 5 - 7 you can compare them with this Issue #1408
We are testing this, to avoid any regression.
Screenshots
Types of changes
Checklist
Further comments
TC-340