[FIX] Modal freezing app after return from the background

[reinaldonetof]

Proposed changes

This issue was found the first time when the user opened the announcement and the announcement's text is a link. Then the user pressed the link and should open the web browser outside of the app. This behavior was forcing the app to go to the background, then when the user resume the app again and tried to close the modal, the app was freezing. This is a known behavior when using a modal as you can see here: facebook/react-native#32504

However, to do a workaround in this case, we aren't re-render the RoomView at the exact time that the app goes to the background, although we are forced to close the modal when resuming the app again and calling the observable again to the list's query.

Issue(s)

How to test or reproduce

• Create a channel
• Add an announcement with only a link: e.g: GitHub: Let’s build from here
• Click on the announcement
• Click on the link
• Go back to the app

Screenshots

Before

Screen.Recording.2022-12-30.at.18.53.51.mov

Screen.Recording.2022-12-30.at.18.54.32.mov

After

Screen.Recording.2022-12-30.at.18.52.44.mov

Types of changes

• Bugfix (non-breaking change which fixes an issue)
• Improvement (non-breaking change which improves a current function)
• New feature (non-breaking change which adds functionality)
• Documentation update (if none of the other choices apply)

Checklist

• I have read the CONTRIBUTING doc
• I have signed the CLA
• Lint and unit tests pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works (if applicable)
• I have added necessary documentation (if applicable)
• Any dependent changes have been merged and published in downstream modules

Further comments

TC-340

[dnlsilva]

Wouldn't it be simpler to just disappear the modal before opening the link?

[reinaldonetof]

Wouldn't it be simpler to just disappear the modal before opening the link?

yeap, but you need to keep in mind that if you minimize the app, then reopen it again, will freeze the app too. So, the flow to freeze the app isn't only when clicking on the link.

[diegolmello]

We shouldn't do this.
It's going to be a mess to remove it later.

What if you just hide the modal before going background?

[reinaldonetof]

The pr #4795 is fixing this issue