[FIX] Dealing well with pre-configured tags in Omnichannel#3298
Merged
diegolmello merged 13 commits intodevelopfrom Aug 23, 2021
Merged
[FIX] Dealing well with pre-configured tags in Omnichannel#3298diegolmello merged 13 commits intodevelopfrom
diegolmello merged 13 commits intodevelopfrom
Conversation
reinaldonetof
commented
Jul 26, 2021
…nnel and disable the multiselect
…Rocket.Chat.ReactNative into fix.tags-omnichannel
gerzonc
suggested changes
Aug 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Users should be able to select tags and save room.
Depends on #3294
Issue(s)
The UI/UX of Omnichannel tags is not good. The App must be compatible with either pre-configured tags or allow agents to set the tags they want, but currently, it seems agents just can't use it properly.
How to test or reproduce
1 - Activate Omnicahnnel -> https://docs.rocket.chat/guides/omnichannel-guides/omnichannel-admins-guide
2 - Go to Omnichannel Tags (Enterprise Edition)
3 - Create one or more Tags -> https://docs.rocket.chat/guides/omnichannel-guides/omnichannel-manger-guides/tags
4 - Start a new chat through Livechat
5 - Take the Chat in the queue
6 - Go to Room Information
7 - Edit Room
In addition, this PR introduced a new rule that Omnichannel's PM noticed, that is: depending on the permission that the agent has, he can edit the user fields only when he has the permission
edit-omnichannel-contactand to edit the rooms field only when has the permissionedit-livechat-room-customfields. So, if the agent has both permissions, he could edit all the inputs, but If he doesn't have any permission, some inputs will be disabled.Screenshots
Before
After
Untitled.mov
Types of changes
Checklist
Further comments