Skip to content

[FIX] Dealing well with pre-configured tags in Omnichannel#3298

Merged
diegolmello merged 13 commits intodevelopfrom
fix.tags-omnichannel
Aug 23, 2021
Merged

[FIX] Dealing well with pre-configured tags in Omnichannel#3298
diegolmello merged 13 commits intodevelopfrom
fix.tags-omnichannel

Conversation

@reinaldonetof
Copy link
Contributor

@reinaldonetof reinaldonetof commented Jul 26, 2021

Proposed changes

Users should be able to select tags and save room.

Depends on #3294

Issue(s)

The UI/UX of Omnichannel tags is not good. The App must be compatible with either pre-configured tags or allow agents to set the tags they want, but currently, it seems agents just can't use it properly.

How to test or reproduce

1 - Activate Omnicahnnel -> https://docs.rocket.chat/guides/omnichannel-guides/omnichannel-admins-guide
2 - Go to Omnichannel Tags (Enterprise Edition)
3 - Create one or more Tags -> https://docs.rocket.chat/guides/omnichannel-guides/omnichannel-manger-guides/tags
4 - Start a new chat through Livechat
5 - Take the Chat in the queue
6 - Go to Room Information
7 - Edit Room

In addition, this PR introduced a new rule that Omnichannel's PM noticed, that is: depending on the permission that the agent has, he can edit the user fields only when he has the permission edit-omnichannel-contact and to edit the rooms field only when has the permission edit-livechat-room-customfields. So, if the agent has both permissions, he could edit all the inputs, but If he doesn't have any permission, some inputs will be disabled.

Screenshots

Before

Screen Shot 2021-07-26 at 11 58 42

After

Untitled.mov

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@reinaldonetof reinaldonetof self-assigned this Jul 26, 2021
@reinaldonetof reinaldonetof changed the title [FIX] Dealing well with pre-configured tags [FIX] Dealing well with pre-configured tags in Omnichannel Jul 26, 2021
Copy link
Contributor

@gerzonc gerzonc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@diegolmello diegolmello merged commit 36ac646 into develop Aug 23, 2021
@diegolmello diegolmello deleted the fix.tags-omnichannel branch August 23, 2021 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants