Skip to content

fix(frontend): read transcription_model key consistently in ASR config UI #859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Bartok9 wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −1
Open

fix(frontend): read transcription_model key consistently in ASR config UI #859

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/rai_core/rai/frontend/configurator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -467,7 +467,7 @@ def on_wake_word_threshold_change():

# Get the current vendor from config and convert to display name
current_vendor = st.session_state.config.get("asr", {}).get(
"transciption_model", TRANSCRIBE_MODELS[0]
"transcription_model", TRANSCRIBE_MODELS[0]
)

asr_vendor = st.selectbox(
Expand Down
8 changes: 8 additions & 0 deletions tests/frontend/test_configurator_asr_key.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
"""Regression: ASR vendor select must read the same config key the on_change writer uses."""
from pathlib import Path

def test_configurator_reads_transcription_model_key():
text = Path("src/rai_core/rai/frontend/configurator.py").read_text()
assert "\"transciption_model\"" not in text
assert "config[\"asr\"][\"transcription_model\"]" in text
assert "\"transcription_model\", TRANSCRIBE_MODELS[0]" in text