Skip to content

Merge 'upstream/master' (114be7f4) #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

EricCousineau-TRI
Copy link
Collaborator

@EricCousineau-TRI EricCousineau-TRI commented Apr 18, 2021

For the author:

  • Ensure downstream CI passes (including Mac):

For the reviewer:

  • Does the commit title look correct? (does it only contain up to
    <sha_new> of upstream?)
  • Are the canary builds "correct"? (look at the checks; for each CI configuration, expand the output
    under Python tests (which are for C++17) - we shouldn't be accidentally missing tests, etc.)
    • CI / 🐍 3.6 • ubuntu-latest • x64 [...]: base vs. this PR's results for
      CI / 🐍 3.6 • ubuntu-latest • x64
    • CI / 🐍 3.9 • macos-latest • x64: base vs. this PR's results for
      CI / 🐍 3.9 • macos-latest • x64
  • Do the drake-specific changes look good? (all commits after the merge
    commit)

This change is Reviewable

rwgk and others added 15 commits March 5, 2021 17:45
…ta to std::chrono::duration (pybind#2870)

* Use correct duration representation when casting from datetime.timdelta to std::chrono::duration

* When asserting datetime/timedelta/date/time we can equality-compare whole objects
* Adding suppression for pypocketfft.

* Generalize existing pypocketfft Valgrind suppression

Co-authored-by: Yannick Jadoul <yannick.jadoul@belgacom.net>
* Pybind11Extension add the "/EHsc /bigobj /std:c++14" flags on Windows.
  This is good for Visual C++ but not for Mingw.
* According
  https://github.com/msys2/MINGW-packages/blob/master/mingw-w64-python2/0410-MINGW-build-extensions-with-GCC.patch
  sysconfig.get_platform() is the way to check for a Mingw64
…2923)

env: Add surrogate for pytest.deprecated_call for ptyest<3.9
* Adding PyGILState_Check() in object_api<>::operator().

* Enabling PyGILState_Check() for Python >= 3.6 only.

Possibly, this explains why PyGILState_Check() cannot safely be used with Python 3.4 and 3.5:

python/cpython#10267 (comment)

* Adding simple micro benchmark.

* Reducing test time to minimum (purely for coverage, not for accurate results).

* Fixing silly oversight.

* Minor code organization improvement in test.

* Adding example runtimes.

* Removing capsys (just run with `-k test_callback_num_times -s` and using `.format()`.
* chore: add myself to CODEOWNERS

This will ensure I get notified about pull requests where these files change.

* Update .github/CODEOWNERS
)

* Add a failure test for overloaded functions

* Allow function pointer extraction from overloaded functions
* correcting Werror for Intel

* adding ward for Intel

* adding wards for intel

* another ward for Intel

* missed one intel ward

* exact match for intel compiler

* removing inline limits

* disable warnings about inline limits

* formatter suggestion

* more indent

* hopefully make formatter happy

* addressed review

* fix &&

* Update tests/CMakeLists.txt

Co-authored-by: Henry Schreiner <HenrySchreinerIII@gmail.com>

Co-authored-by: Henry Schreiner <HenrySchreinerIII@gmail.com>
# Conflicts:
#	.github/workflows/format.yml
#	tests/test_multiple_inheritance.cpp
@EricCousineau-TRI
Copy link
Collaborator Author

Close in lieu of #57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants