-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update drake and allow using local copy #39
Update drake and allow using local copy #39
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @mpetersen94 and @sammy-tri)
environ.bzl, line 4 at r1 (raw file):
# vi: set ft=python : # Copyright (c) 2018, Toyota Research Institute.
The top level LICENSE
file already contains this text. Do we need to reproduce it here? (Asking because I'm not sure, I could maybe be persuaded.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked that the local copy support works, waiting on license question.
Reviewed 1 of 3 files at r1.
Reviewable status: 1 of 3 files reviewed, 1 unresolved discussion (waiting on @mpetersen94 and @sammy-tri)
7e1f6ed
to
744fa86
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 3 files reviewed, 1 unresolved discussion (waiting on @sammy-tri)
environ.bzl, line 4 at r1 (raw file):
Previously, sammy-tri (Sam Creasey) wrote…
The top level
LICENSE
file already contains this text. Do we need to reproduce it here? (Asking because I'm not sure, I could maybe be persuaded.)
Done. I think you are right (didn't notice the LICENSE file)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 3 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @mpetersen94)
@sammy-tri for review
This change is