Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update drake and allow using local copy #39

Merged
merged 1 commit into from
Oct 20, 2021

Conversation

mpetersen94
Copy link
Contributor

@mpetersen94 mpetersen94 commented Oct 15, 2021

@sammy-tri for review


This change is Reviewable

Copy link
Collaborator

@sammy-tri sammy-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @mpetersen94 and @sammy-tri)


environ.bzl, line 4 at r1 (raw file):

# vi: set ft=python :

# Copyright (c) 2018, Toyota Research Institute.

The top level LICENSE file already contains this text. Do we need to reproduce it here? (Asking because I'm not sure, I could maybe be persuaded.)

Copy link
Collaborator

@sammy-tri sammy-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked that the local copy support works, waiting on license question.

Reviewed 1 of 3 files at r1.
Reviewable status: 1 of 3 files reviewed, 1 unresolved discussion (waiting on @mpetersen94 and @sammy-tri)

Copy link
Contributor Author

@mpetersen94 mpetersen94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 3 files reviewed, 1 unresolved discussion (waiting on @sammy-tri)


environ.bzl, line 4 at r1 (raw file):

Previously, sammy-tri (Sam Creasey) wrote…

The top level LICENSE file already contains this text. Do we need to reproduce it here? (Asking because I'm not sure, I could maybe be persuaded.)

Done. I think you are right (didn't notice the LICENSE file)

Copy link
Collaborator

@sammy-tri sammy-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 3 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @mpetersen94)

@sammy-tri sammy-tri merged commit 1faf413 into RobotLocomotion:master Oct 20, 2021
@mpetersen94 mpetersen94 deleted the map.drake_update branch October 21, 2021 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants