Remove workaround for brew/setup-python conflict #479
Conversation
tyler-yankee
left a comment
tyler-yankee
left a comment
There was a problem hiding this comment.
+a:@mwoehlke-kitware for feature review (or delegation), please?
Reviewable status: all discussions resolved, LGTM missing from assignee mwoehlke-kitware, platform LGTM missing (waiting on @mwoehlke-kitware)
tyler-yankee
moved this to In review
in build system, continuous integration, distribution
|
Looks like @svenevs wrote the original patch, maybe he has a better idea what's going on? |
|
Hey there 🙂 Response from a phone, actions/runner-images#11545 (comment) back when we added the hacks it was because the brew python and GHA python would stomp on each other, IIRC because drake does brew upgrade it would find symlinks it didn't recognize and fail. I believe it also only happened when there was a new python involved but don't really recall. It appears that they might have fixed this problem for the GHA runners based on the linked comment so could be safe to remove? If it pokes it's head up in a few months during a python upgrade, then just bring it back. But ideally they've fixed it and the hack can just go away forever. Hope that helps some! |
tyler-yankee
force-pushed
the
remove-setup-python-hack
branch
from
c919288 to
7c17cc2
Compare
tyler-yankee
left a comment
tyler-yankee
left a comment
There was a problem hiding this comment.
Thanks for providing context!
I had opened this as a draft to see if it'd be feasible to remove, and am mostly trusting in the CI result paired with the linked issue comment.
Reviewable status: all discussions resolved, LGTM missing from assignee mwoehlke-kitware, platform LGTM missing (waiting on @mwoehlke-kitware)
3 participants
See actions/runner-images#9966 for the upstream change.
This change is