#114 skip pre-release versions when picking the last minor release #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous assertion was expecting latest *patch* release, which isn't what the `PickLastMinorVersionFromCollection` system is supposed to do.
…ection logic Pre-releases are not to be considered for default stability checks.
This was referenced Feb 11, 2019
schmunk42
reviewed
Feb 11, 2019
| @@ -28,6 +28,7 @@ public function lastStableMinorVersionForCollectionProvider() : array | |||
| ['2.2.0', ['1.2.0', '2.2.0', '2.2.1', '1.2.1']], | |||
| ['2.2.0', ['1.2.0', '2.2.0', '2.2.0-alpha1', '2.2.1', '1.2.1']], | |||
| ['2.2.0', ['1.2.0', '2.2.0-alpha1', '2.2.0', '2.2.1', '1.2.1']], | |||
| ['2.6.0', ['1.1.1', '3.0.0-alpha1', '2.7.0-beta1', '2.6.2', '2.0.0', '2.6.1', '2.6.0']], | |||
There was a problem hiding this comment.
Shouldn't this be 2.6.2?
There was a problem hiding this comment.
I've explicitly changed it in 33e851f (see commit message)
There was a problem hiding this comment.
Sorry, didn't get the "lastMinorVersion" thingy....
There was a problem hiding this comment.
That's alright - it was a design decision :-)
asgrim
approved these changes
Feb 11, 2019
There was a problem hiding this comment.
Nice, yes this should've been caught earlier, thanks @schmunk42 and @Ocramius
asgrim
deleted the
fix/#114-pick-last-minor-version-from-collection-fails-with-alpha-versions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #114
Fixes #117