Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#114 "Undefined offset: 0" error in PickLastMinorVersionFromCollection #117

Closed
wants to merge 1 commit into from
Closed

#114 "Undefined offset: 0" error in PickLastMinorVersionFromCollection #117

wants to merge 1 commit into from

Conversation

schmunk42
Copy link
Contributor

Test fails locally with

There was 1 error:

1) RoaveTest\BackwardCompatibility\Git\PickLastMinorVersionFromCollectionTest::testForRepository with data set #6 ('2.6.2', array('1.1.1', '3.0.0-alpha1', '2.7.0-beta1', '2.6.2', '2.0.0', '2.6.1', '2.6.0'))
Undefined offset: 0

/app/src/Git/PickLastMinorVersionFromCollection.php:48
/app/test/unit/Git/PickLastMinorVersionFromCollectionTest.php:50

as described in #114

@Ocramius Ocramius changed the title added test for issue #114 #114 "Undefined offset: 0" error in PickLastMinorVersionFromCollection Feb 11, 2019
@Ocramius Ocramius mentioned this pull request Feb 11, 2019
Merged
@Ocramius Ocramius self-assigned this Feb 11, 2019
@Ocramius Ocramius added this to the 2.1.0 milestone Feb 11, 2019
@Ocramius
Copy link
Member

Moved to #118

Closing as duplicate of #118

@Ocramius Ocramius closed this Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Ocramius Ocramius

Labels
bug duplicate
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@schmunk42 @Ocramius